This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Convert to solidity #172
Open
Convert to solidity #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4th checkpoint.
Next step will run test for solidity code.....
I might to use vyper-abi on pytest of solidity casper.
Not: But this is old version source.
Because Strunct[] in Struct not support in Solidity.
…est_chain_initialization.py - arrays need define getter function. so index type different. - can not define struct[]. so, convert to uint168 from Decimal.Data[]. - allocate the arrays size. Solidity is do not automatically allocation of array size.
Bypass overflow when mul.
Change Decimal allow sign integer. Getter is allow unallocate access.
Implement Sign Decimal calculation logic. fix some miss-logic, mostly ABI differ.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code passed tests completely. I converted to Solidity for learning casper.
I want to feed back to community.