Remove solc dependency on the main filler (python source code)

[marioevz]

TL;DR Remove solc dependency from uv run fill and only leave it at uv run fill --fill-static-tests:

• Remove yul from python tests referencing it:
  • tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py
  • tests/constantinople/eip1014_create2/test_recreate.py
  • tests/homestead/yul/test_yul_example.py
• Move all yul plugin functionality from src/pytest_plugins/shared/execute_fill.py to src/pytest_plugins/filler/static_filler.py:
  • Remove exports from src/ethereum_test_tools/__init__.py so it cannot be referenced in python tests anymore.
  • Remove pytest_plugins.solc.solc and pytest_plugins.filler.static_filler plugins from pytest.ini to be dynamically loaded when the --fill-static-tests flag is used.
  • Also move the flag --fill-static-tests from src/pytest_plugins/filler/static_filler.py to src/pytest_plugins/shared/execute_fill.py: We have to do this in order to read the flag in a plugin that is always loaded.
  • Move yul fixture from src/pytest_plugins/shared/execute_fill.py to src/pytest_plugins/filler/static_filler.py so it's only applied to the tests when filling static tests.

[felix314159]

• Can we also remove ./src/pytest_plugins/solc/tests/test_solc.py? I would like to avoid issues when running sth like uvx --with=tox-uv tox
• solc-select is not mentioned, I would like to assume that solc is available in PATH and completely remove this dependency and all logic associated with it
• Question in regards to Remove yul from python tests referencing it: Do you us to rewrite the tests to use opcode language or do you want to just remove all Python tests that use yul?

[marioevz]

• Can we also remove ./src/pytest_plugins/solc/tests/test_solc.py? I would like to avoid issues when running sth like uvx --with=tox-uv tox

  • solc-select is not mentioned, I would like to assume that solc is available in PATH and completely remove this dependency and all logic associated with it

The problem with these two points is that we use --solc-version during fixture building:

execution-spec-tests/.github/actions/build-fixtures/action.yaml

Line 37 in bb4289a

uv run fill -n ${{ steps.evm-builder.outputs.x-dist }} --evm-bin=${{ steps.evm-builder.outputs.evm-bin }} --solc-version=${{ steps.properties.outputs.solc }} --skip-evm-dump ${{ steps.properties.outputs.fill-params }} --output=fixtures_${{ inputs.release_name }}.tar.gz --build-name ${{ inputs.release_name }}

We could modify the action to install solc in a prior step for it to be available in the machine and completely remove this flag, and also potentially completely remove ./src/pytest_plugins/solc.

* Question in regards to `Remove yul from python tests referencing it`: Do you us to rewrite the tests to use opcode language or do you want to just remove all Python tests that use yul?

Delete tests that focus on yul (only tests/homestead/yul/test_yul_example.py), port others.

[felix314159]

Buy why do we need a solc-version flag in the first place, afaik all tests could just be filled with the help of e.g. v0.8.24. IMO it would be much simpler to just pull a static solc binary from the official release and put it at location X and use it from there than to maintain this solc-select logic and have this flag. And in CI this is not even needed because we do not fill static tests all the time.

If we would need fine-grained control over a wide range of different solc versions (and have a test specifically for version 0.8.x and another test for version 0.8.y) I would understand the need for this --solc-version flag, but in the current state of things it seems to me like this is overengineered

[felix314159]

Solved by merging #1779