feat(forks,plugins): Fork transition test marker

[marioevz]

🗒️ Description

Adds two keyword parameters to the valid_at_transition_to marker:

• subsequent_forks: bool: If set to True, the test will be generated for the transition fork to the specified fork name, but also for all subsequent transition forks. Default is False.
• until: str | None: Specify an end to the fork transitions to be filed when using subsequent_forks=True. Implies subsequent_forks=True. Default is None.

E.g.

@pytest.mark.valid_at_transition_to("Cancun", subsequent_forks=True)

produces tests on ShanghaiToCancunAtTime15k and CancunToPragueAtTime15k, and any transition fork after that.

Also added unit tests in src/pytest_plugins/forks/tests/test_markers.py.

Implementing tests for EIP-7691 in a separate PR, as required by lack of coverage pointed out in this thread: https://discord.com/channels/595666850260713488/1329093054698881087

Validity Markers Refactor

All validity markers are now defined as classes that subclass a base validity marker class, ValidityMarker.

This allows simpler validity marker definition, and easier handling of keyword arguments if it is the case that a validity marker supports them. See ValidAtTransitionTo for an example of how such a validity marker is defined.

🔗 Related Issues

None

✅ Checklist

• All: Set appropriate labels for the changes.
• All: Considered squashing commits to improve commit history.
• All: Added an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
• Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
• Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

[danceratopz]

How about:

@pytest.mark.valid_at_transition_to("Cancun", subsequent_transitions=True, until="Osaka")

[marioevz]

How about:

@pytest.mark.valid_at_transition_to("Cancun", subsequent_transitions=True, until="Osaka")

Addresed on the latest commit, which also includes a nice refactor of all validity markers into separate classes:

execution-spec-tests/src/pytest_plugins/forks/forks.py

Lines 711 to 747 in 73ab2c9

	class ValidAtTransitionTo(ValidityMarker, mutually_exclusive=True):
	"""Marker to specify that a test is valid at the transition to a specific fork."""
	def process_with_args(
	self, *fork_args, subsequent_forks: bool = False, until: str | None = None
	) -> Set[Fork]:
	"""Process the fork arguments."""
	forks: Set[Fork] = self.process_fork_arguments(*fork_args)
	until_forks: Set[Fork] | None = (
	None if until is None else self.process_fork_arguments(until)
	)
	if len(forks) == 0:
	pytest.fail(
	f"'{self.test_name}': Missing fork argument with 'valid_at_transition_to' "
	"marker."
	)
	if len(forks) > 1:
	pytest.fail(
	f"'{self.test_name}': Too many forks specified to 'valid_at_transition_to' "
	"marker."
	)
	resulting_set: Set[Fork] = set()
	for fork in forks:
	resulting_set |= transition_fork_to(fork)
	if subsequent_forks:
	for transition_forks in (
	transition_fork_to(f) for f in self.all_forks if f > fork
	):
	for transition_fork in transition_forks:
	if transition_fork and (
	until_forks is None
	or any(transition_fork <= until_fork for until_fork in until_forks)
	):
	resulting_set.add(transition_fork)
	return resulting_set

[winsvega]

have a couple of questions

[marioevz]

@danceratopz merged your suggestion from the other PR, this one should be ready 😄

[danceratopz]

The refactoring of the validity markers is really nice! It adds much more structure to this plugin (I think this is one of the most complex parts of our pytest code). And really nice additional tests for these, btw! Few minor comments below.