Skip to content

Conversation

@marioevz
Copy link
Member

🗒️ Description

Updates EIP-7685 to take into account the following execution-apis PRs:

🔗 Related Issues

#1094

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Changes EL client test cases in `./tests` type:refactor Type: Refactor labels Jan 21, 2025
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for ethereum/execution-apis#622!

I don't see how it adds coverage for ethereum/execution-apis#623? But it's late 😆

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how it adds coverage for ethereum/execution-apis#623? But it's late 😆

Thanks for the aysnc heads up, this is covered here:

# - Duplicate request tests
for request_type, (eoa_request, block_request) in all_request_types.items():
combinations.append(
pytest.param(
[eoa_request],
Requests(block_request).requests_list * 2,
BlockException.INVALID_REQUESTS,
id=f"duplicate_{request_type}_request",
),
)

LGTM!

@marioevz marioevz merged commit 00e8ce8 into main Jan 22, 2025
21 checks passed
@marioevz marioevz deleted the engine-api-requests-error branch January 22, 2025 23:25
fselmo pushed a commit to fselmo/execution-spec-tests that referenced this pull request Jan 24, 2025
…ethereum#1097)

* fix(tests): EIP-7685: Return Engine API error code for invalid params

* chore(tests): improve fixture docstring

* Update tests/prague/eip7685_general_purpose_el_requests/conftest.py

Co-authored-by: danceratopz <[email protected]>

---------

Co-authored-by: danceratopz <[email protected]>
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
…ethereum#1097)

* fix(tests): EIP-7685: Return Engine API error code for invalid params

* chore(tests): improve fixture docstring

* Update tests/prague/eip7685_general_purpose_el_requests/conftest.py

Co-authored-by: danceratopz <[email protected]>

---------

Co-authored-by: danceratopz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:tests Scope: Changes EL client test cases in `./tests` type:refactor Type: Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants