-
Notifications
You must be signed in to change notification settings - Fork 187
feat(tests): eip-7883 & eip-7823 modexp cases #1579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments, I didn't fully review yet.
64a691b to
f3996c0
Compare
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should work on merging this and then iteratively complete the checklist introduced in #1679 with follow-up PRs.
tests/osaka/eip7823_modexp_upper_bounds/test_modexp_upper_bounds.py
Outdated
Show resolved
Hide resolved
This reverts commit e0857e5.
96b8d02 to
ec4c799
Compare
* feat(tests): start basic eip-7883 cases. * chore: eels for eip-7883. * refactor(types): TestParameterGroup into a pydantic model * refactor(tests): Tests using TestParameterGroup * fix(tests): EIP-7883: Fix gas meter * fix(tests): EIP-7883: Gas calc * fix(types): Fix TestParameterGroup * fix(tests): EIP-198: Tox * fix(tests): EIP-152: Tox * fix(tests): EIP-7883: Tox * fix(tests): EIP-7823: Tox * chore(tests): add remaining 7883 test vectors. * fix(tests/eip7823): Make tests compatible with 7825 * fix(tests): EIP-7823,7883 Gas Calculation * Add geth failing test to EIP-7883 * fix guido-4-even expected output * Revert "chore: eels for eip-7883." This reverts commit e0857e5. * fix: remove unused constant * changelog * fix: tox --------- Co-authored-by: Mario Vega <[email protected]>
ποΈ Description
Adds tests cases for the 2 modexp EIPs CFI'd in Fusaka: 7883/7823. Thanks to @marioevz for continuing this PR.
π Related Issues
N/A
β Checklist