Skip to content

Conversation

@spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented May 9, 2025

πŸ—’οΈ Description

Adds tests cases for the 2 modexp EIPs CFI'd in Fusaka: 7883/7823. Thanks to @marioevz for continuing this PR.

πŸ”— Related Issues

N/A

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added scope:tests Scope: Changes EL client test cases in `./tests` fork:osaka Osaka hardfork feature:eof type:feat type: Feature and removed feature:eof labels May 9, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments, I didn't fully review yet.

@spencer-tb spencer-tb force-pushed the spencer-tb/tests/eip-7883 branch from 64a691b to f3996c0 Compare May 20, 2025 12:34
@spencer-tb spencer-tb changed the title feat(tests): eip-7883 modexp gas increase cases feat(tests): eip-7883 & eip-7823 modexp cases May 27, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should work on merging this and then iteratively complete the checklist introduced in #1679 with follow-up PRs.

@marioevz marioevz marked this pull request as ready for review June 4, 2025 12:06
@marioevz marioevz force-pushed the spencer-tb/tests/eip-7883 branch from 96b8d02 to ec4c799 Compare June 4, 2025 12:15
@marioevz marioevz merged commit feb6695 into main Jun 4, 2025
26 checks passed
@marioevz marioevz deleted the spencer-tb/tests/eip-7883 branch June 4, 2025 13:30
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
* feat(tests): start basic eip-7883 cases.

* chore: eels for eip-7883.

* refactor(types): TestParameterGroup into a pydantic model

* refactor(tests): Tests using TestParameterGroup

* fix(tests): EIP-7883: Fix gas meter

* fix(tests): EIP-7883: Gas calc

* fix(types): Fix TestParameterGroup

* fix(tests): EIP-198: Tox

* fix(tests): EIP-152: Tox

* fix(tests): EIP-7883: Tox

* fix(tests): EIP-7823: Tox

* chore(tests): add remaining 7883 test vectors.

* fix(tests/eip7823): Make tests compatible with 7825

* fix(tests): EIP-7823,7883 Gas Calculation

* Add geth failing test to EIP-7883

* fix guido-4-even expected output

* Revert "chore: eels for eip-7883."

This reverts commit e0857e5.

* fix: remove unused constant

* changelog

* fix: tox

---------

Co-authored-by: Mario Vega <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants