refactor(fill,fixtures): rename "engine reorg" to "engine x"; improve pre-allocation group terminology #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
changed the title
… groups' 1/2 Terminology: - 'shared pre-allocation' → 'pre-allocation groups' - 'shared pre-state' → 'pre-allocation groups' Flags: - `--generate-shared-pre` -> `--generate-grouped-pre-allocs` - `--use-shared-pre` -> `--use-grouped-pre-allocs` Method names updated: - `update_shared_pre_state` → `update_pre_alloc_groups` - `compute_shared_pre_alloc_hash` → `compute_pre_alloc_group_hash` - `shared_pre_alloc_folder_path` → `grouped_pre_allocs_folder_path`
Rename command-line flags to align with function and class naming: - --generate-grouped-pre-allocs → --generate-pre-alloc-groups - --use-grouped-pre-allocs → --use-pre-alloc-groups This improves consistency with PreAllocGroups class and related method names throughout the codebase. Updated all flag definitions, config.getoption() calls, property names, and documentation.
danceratopz
force-pushed
the
refactor/rename-engine-reorg-to-engine-x
branch
from
8897f68 to
10b0323
Compare
danceratopz
added a commit
that referenced
this pull request
Jun 18, 2025
5 tasks
marioevz
approved these changes
Jun 18, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
Huge rename! Thanks for this! 👍
danceratopz
added a commit
that referenced
this pull request
Jun 25, 2025
danceratopz
added a commit
that referenced
this pull request
Jun 25, 2025
danceratopz
added a commit
that referenced
this pull request
Jun 30, 2025
danceratopz
added a commit
that referenced
this pull request
Jul 1, 2025
5 tasks
danceratopz
added a commit
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Improves the language around the new fixture format and grouped pre-allocations generation.
Main Terminology Updates
EngineX
BlockchainEngineReorgFixture→BlockchainEngineXFixtureblockchain_test_engine_reorg→blockchain_test_engine_xblockchain_tests_engine_reorg→blockchain_tests_engine_xblockchain_test_engine_reorg.mdtoblockchain_test_engine_x.mdPre-Alloc Groups
Core Files:
src/ethereum_test_fixtures/pre_alloc_groups.py(renamed fromshared_alloc.py)src/pytest_plugins/filler/filler.pysrc/cli/pytest_commands/fill.pysrc/pytest_plugins/filler/fixture_output.pysrc/pytest_plugins/filler/pre_alloc.pyFlag Renames:
--generate-shared-pre→--generate-pre-alloc-groups--use-shared-pre→--use-pre-alloc-groupsClass Renames:
SharedPreStateGroup→PreAllocGroupSharedPreState→PreAllocGroupsMethod Renames:
update_shared_pre_state→update_pre_alloc_groupscompute_shared_pre_alloc_hash→compute_pre_alloc_group_hashshared_pre_alloc_folder_path→pre_alloc_groups_folder_pathVariable Renames:
shared_pre_state→pre_alloc_groupsshared_alloc→pre_alloc_groupshared_allocs→pre_alloc_groupsProperty Renames:
shared_pre_alloc_folder_path→pre_alloc_groups_folder_pathgenerate_shared_pre→generate_pre_alloc_groupsuse_shared_pre→use_pre_alloc_groupsDocumentation Updated:
docs/running_tests/test_formats/blockchain_test_engine_x.md- Comprehensive terminology updatedocs/library/cli/extract_config.mddocs/CHANGELOG.mdsrc/cli/show_pre_alloc_group_stats.py- Help text updates🔗 Related Issues
✅ Checklist