fix(ci): All slow unit tests, remove run_in_serial
#1870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
--t8n-server-urlfill flagAdds a new flag to t8n in order to be able to pass an already-running t8n server to run unit tests.
This allows us to use a single eels resolver server instance in all unit tests and speed up test running considerably.
Remove
run_in_serialThe unit test marker
run_in_serialis removed since now all tests can run in parallel without issues.Improvements
Before
uvx --with=tox-uv tox -e pytestcommand:pytest -c ./pytest-framework.ini -n auto -m 'not run_in_serial'- 103.30s (0:01:43)pytest -c ./pytest-framework.ini -m run_in_serial- 96.13s (0:01:36)After
uvx --with=tox-uv tox -e pytestcommand:pytest -c ./pytest-framework.ini -n auto- 29.46s (0:00:29)🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.