Skip to content

Conversation

@kclowes
Copy link
Collaborator

@kclowes kclowes commented Aug 29, 2025

πŸ—’οΈ Description

Went through the docs checklist and added either N/A as appropriate, or a checkmark using pytest.mark. Also added a couple minor tests that were missing.

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • [ ] Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • [ ] Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@kclowes kclowes added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore type:feat type: Feature fork:osaka Osaka hardfork scope:checklists Scope: ethereum_test_checklists package labels Aug 29, 2025
@LouisTsai-Csie
Copy link
Collaborator

Thanks for this PR! But i notice there are two co-existing systems to mark the checklist item

Based on the documentation. The marker would use the enum style method

@EIPChecklist.TransactionType.Test.IntrinsicValidity.GasLimit.Exact()
def test_exact_intrinsic_gas(state_test: StateTestFiller):
    """Test transaction with exact intrinsic gas limit."""
    # Test implementation
    pass

But i think your current approach also works:

@pytest.mark.eip_checklist("transaction_type/test/intrinsic_validity/gas_limit/exact")
def test_exact_intrinsic_gas(state_test: StateTestFiller):
    """Test transaction with exact intrinsic gas limit."""
    # Test implementation
    pass

Which one should we use for consistency? cc @marioevz as checklist PR owner

@kclowes
Copy link
Collaborator Author

kclowes commented Sep 3, 2025

Yeah, either way does work. I'm happy to use either one, I just went with the existing convention in the file.

@kclowes kclowes force-pushed the chore/7951-update-checklist branch from be09de7 to aff00fc Compare September 5, 2025 20:44
@kclowes kclowes marked this pull request as ready for review September 5, 2025 20:45
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave some comment! Thanks for this

@marioevz
Copy link
Member

marioevz commented Sep 9, 2025

Yeah, either way does work. I'm happy to use either one, I just went with the existing convention in the file.

I think @EIPChecklist.TransactionType.Test.IntrinsicValidity.GasLimit.Exact() is the newer approach and should be used from now on, if you could spend some time to update this in the files you touched it would be very nice too πŸ™

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the comment about how we apply the markers, if we can we should use the newer approach. Thanks for this! :)

@kclowes kclowes force-pushed the chore/7951-update-checklist branch 2 times, most recently from 1a9a09b to e93082f Compare September 10, 2025 21:30
@kclowes kclowes force-pushed the chore/7951-update-checklist branch from e93082f to 04491e2 Compare September 10, 2025 22:04
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem from my side! I will update my PR accordingly as well!

Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All comments applied so merging.

@spencer-tb spencer-tb merged commit e9045fc into ethereum:main Sep 12, 2025
16 checks passed
kclowes added a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
* chore(tests): Update pytest markers for checklist docs

* chore(tests): Remove unknown markers

* bugfix(tests): Use eip kwarg to allow checklist to find tests

* chore(tests): Add eip_checklist_external_coverage.txt

* chore(tests): Add checklist marks for excessive gas usage and codecov test coverage

* chore(tests): Add max values checklist decorator

* chore(tests): Move old eip_checklist marker style to new EIPCheckList decorator

* bugfix(tests): Check calling precompile when value gets sent

* Final fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork:osaka Osaka hardfork scope:checklists Scope: ethereum_test_checklists package scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore type:feat type: Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants