-
Notifications
You must be signed in to change notification settings - Fork 187
chore(tests): Update 7951 Checklist Markers #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): Update 7951 Checklist Markers #2088
Conversation
|
Thanks for this PR! But i notice there are two co-existing systems to mark the checklist item Based on the documentation. The marker would use the @EIPChecklist.TransactionType.Test.IntrinsicValidity.GasLimit.Exact()
def test_exact_intrinsic_gas(state_test: StateTestFiller):
"""Test transaction with exact intrinsic gas limit."""
# Test implementation
passBut i think your current approach also works: @pytest.mark.eip_checklist("transaction_type/test/intrinsic_validity/gas_limit/exact")
def test_exact_intrinsic_gas(state_test: StateTestFiller):
"""Test transaction with exact intrinsic gas limit."""
# Test implementation
passWhich one should we use for consistency? cc @marioevz as checklist PR owner |
|
Yeah, either way does work. I'm happy to use either one, I just went with the existing convention in the file. |
be09de7 to
aff00fc
Compare
LouisTsai-Csie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave some comment! Thanks for this
I think |
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the comment about how we apply the markers, if we can we should use the newer approach. Thanks for this! :)
1a9a09b to
e93082f
Compare
e93082f to
04491e2
Compare
LouisTsai-Csie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem from my side! I will update my PR accordingly as well!
spencer-tb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! All comments applied so merging.
* chore(tests): Update pytest markers for checklist docs * chore(tests): Remove unknown markers * bugfix(tests): Use eip kwarg to allow checklist to find tests * chore(tests): Add eip_checklist_external_coverage.txt * chore(tests): Add checklist marks for excessive gas usage and codecov test coverage * chore(tests): Add max values checklist decorator * chore(tests): Move old eip_checklist marker style to new EIPCheckList decorator * bugfix(tests): Check calling precompile when value gets sent * Final fixes
ποΈ Description
Went through the docs checklist and added either N/A as appropriate, or a checkmark using
pytest.mark. Also added a couple minor tests that were missing.π Related Issues or PRs
N/A.
β Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.[ ] Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.[ ] Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned@ported_frommarker.