feat(FOCIL): EIP-7805 Test Cases #2299

PelleKrab · 2025-10-15T18:17:18Z

🗒️ Description

Initial checklist for EIP-7805 (FOCIL) execution tests.

✅ Checklist

All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
```
uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
```
All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
All: Considered adding an entry to CHANGELOG.md.
All: Considered updating the online docs in the ./docs/ directory.
All: Set appropriate labels for the changes (only maintainers can apply labels).
Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

spencer-tb · 2025-10-16T08:57:02Z

Hey, just an FYI. We are about to finalize "The Weld" - moving EEST to EELS. It's best to keep this PR up here in EEST for now. We will then ask you to reopen the PR but in EELS somepoint next week. Hope that okay!

More context: https://steel.ethereum.foundation/blog/blog_posts/2025-09-11_weld-announcement/

jihoonsong

Generally it has a good structure and looks good. Appreciate this effort, thanks!

tests/amsterdam/eip7805_forkchoice_enforced_inclusion_lists/test_cases.md

jihoonsong · 2025-10-16T15:09:40Z

tests/amsterdam/eip7805_forkchoice_enforced_inclusion_lists/test_cases.md

+| **Inclusion List Building** |
+| `test_il_builder_creates_valid_list_from_txs` | Ensure the IL builder can build a valid `InclusionList` from the mempool. | Alice and Bob submit valid transactions to the mempool | The builder MUST produce a structurally valid `InclusionList`. The list must be properly encoded. | 🟡 Planned |
+| `test_il_builder_respects_size_limit` | Ensure the IL builder does not create a list that exceeds the `MAX_BYTES_PER_INCLUSION_LIST` limit. | Provide the builder with more transactions than can fit within the size limit. | The builder MUST create an `InclusionList` that is less than or equal to the size limit. It MUST NOT produce an oversized list. | 🟡 Planned |
+| **Block Validation** |


We could add more tests such as:

When the gas left is insufficient to add omitted IL transactions.

When omitted IL transactions are invalidated by other transactions in a payload. There will be multiple scenarios and we'd want to include as many as we can, especially regarding AA transactions.

AA transactions would be interesting and make our tests very robust, if we could have exhaustive tests for AA.

…ist_txs and fixed grammar mistakes

jihoonsong · 2025-10-21T09:41:02Z

tests/amsterdam/eip7805_forkchoice_enforced_inclusion_lists/test_cases.md

+| `test_focil_builder_includes_valid_inclusion_list_txs` | Ensure the produced block includes all valid transactions from the provided inclusion list. | The EL is asked to build a block with an inclusion list containing several valid transactions. | The produced block MUST contain all the valid transactions from the inclusion list. | 🟡 Planned |
+| `test_focil_builder_ignores_invalid_inclusion_list_transactions` | Ensure `produce_execution_payload` does not include inclusion list transactions that are invalid against the parent state. | The EL is asked to build a block with an inclusion list containing a mix of valid and invalid (e.g., bad nonce) transactions. | The produced block MUST include the valid inclusion list transactions and MUST NOT include the invalid ones. | 🟡 Planned |
+| `test_focil_block_builder_handles_empty_inclusion_list` | Ensure a valid block is built when the inclusion list is empty. | The EL is asked to build a block with an empty inclusion list. | The builder MUST produce a valid block. | 🟡 Planned |
+| `test_focil_builder_handles_inclusion_list_tx_becoming_invalid` | Ensure builder correctly omits an inclusion list transaction that becomes invalid due to a preceding inclusion list transaction. | The inclusion list is `[tx_A, tx_B]`. Both are from the same EOA with nonce `N`. Both are valid against the parent state. | The builder MUST include `tx_A`. `tx_B` (with nonce `N`) becomes invalid and MUST be omitted from the block. | 🟡 Planned |


This is good. Could you add more tests that cover other cases such as both tx_A and tx_B are from the same EOA and have the right nonce (whatever their order is) but including the prior transaction makes the EOA cannot afford the latter. Also when a block is full and not all IL transactions are included. Any cases that can make this list exhaustive are good.

I added 3 more, still trying to come up with more. Lemme know if anymore come to mind.

tests/amsterdam/eip7805_forkchoice_enforced_inclusion_lists/test_cases.md

jihoonsong · 2025-10-21T10:08:44Z

tests/amsterdam/eip7805_forkchoice_enforced_inclusion_lists/test_cases.md

+
+| Function Name | Goal | Setup | Expectation | Status |
+|---------------|------|-------|-------------|--------|
+| **Inclusion list Building** |


When we test this, we would pass a payload and IL transactions, right? We could set up various payloads, which falls into three folds: contains all IL transactions and contains some of IL transactions and is valid/ invalid. I think some test cases in this section can be divided into subcategories of those three cases.

For Inclusion List Building we are just testing the engine_getInclusionList functionality, but I agree we splitting the up payload IL pairs for the other test.

Should these pairs be speced out in this document or do you think a separate md could be useful?

Do you mean the test inputs?

yes, the payloads. We could define them more indepth in checklist, a separate md, or just in the python test.

We could use pytest to parameterize it. For example, this test has 8 inputs (or variants in the context of their website.)

For pytest, you could refer to this one.

Thanks @raxhvl for sharing knowledge 👍

jihoonsong

I remember that I left a comment on inclusionListTransactions but I feel like just referring it as inclusion list may enhance readability in some cases. I don't want to split hairs too much, please feel free to change it, if you found anything can be improved :)

tests/amsterdam/eip7805_forkchoice_enforced_inclusion_lists/test_cases.md

spencer-tb · 2025-10-27T11:14:36Z

Hey! We are practically finished Weld-ing so could you please re-open this PR in EELS?

Could we also move it here: https://github.com/ethereum/execution-specs/tree/forks/osaka/tests/unscheduled
Once FOCIL becomes SFI'd we'd then move it to tests/amsterdam! Thanks :)

PelleKrab added 4 commits October 14, 2025 20:31

Added: EIP-7805 FOCIL test cases

1fe99ca

Revise EIP-7805 FOCIL test cases for clairity

fbe6195

initial spec test checklist

e33ef18

fix(FOCIL): typos

f685a61

jihoonsong reviewed Oct 16, 2025

View reviewed changes

Fixed wording and removed unneeded tests

3592dde

PelleKrab force-pushed the focil branch from d161d5d to 3592dde Compare October 18, 2025 21:02

PelleKrab added 2 commits October 18, 2025 15:22

specified IL builder as IL committee member

60db8d2

Added test_focil_block_validation_accepts_two_independent_inclusion_l…

9980486

…ist_txs and fixed grammar mistakes

jihoonsong reviewed Oct 21, 2025

View reviewed changes

PelleKrab added 2 commits October 21, 2025 10:54

fixed ambiguous language

82531a2

Added 3 builder tests, testing tx interplay validity

ac5dee1

jihoonsong reviewed Oct 22, 2025

View reviewed changes

Removed extraneous test and nits

5f440c1

raxhvl changed the title ~~feat(FOCIL): EIP-7805 Checklist~~ feat(FOCIL): EIP-7805 Test Cases Oct 23, 2025

jihoonsong mentioned this pull request Oct 23, 2025

FOCIL Breakout #22, October 21, 2025 ethereum/pm#1774

Closed

3 tasks

PelleKrab mentioned this pull request Oct 28, 2025

feat(FOCIL): EIP-7805 Test Cases ethereum/execution-specs#1709

Open

8 tasks

PelleKrab closed this Oct 28, 2025

Uh oh!

feat(FOCIL): EIP-7805 Test Cases #2299

feat(FOCIL): EIP-7805 Test Cases #2299

Uh oh!

Conversation

PelleKrab commented Oct 15, 2025

🗒️ Description

✅ Checklist

Uh oh!

spencer-tb commented Oct 16, 2025

Uh oh!

jihoonsong left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jihoonsong Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jihoonsong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spencer-tb commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jihoonsong left a comment •

edited

Loading

jihoonsong Oct 22, 2025 •

edited

Loading