-
Notifications
You must be signed in to change notification settings - Fork 374
Open
Labels
A-test-benchmarkArea: Tests Benchmarks—Performance measurement (eg. `tests/benchmark/*`, `p/t/s/e/benchmark/*`)Area: Tests Benchmarks—Performance measurement (eg. `tests/benchmark/*`, `p/t/s/e/benchmark/*`)C-enhanceCategory: an improvement or new featureCategory: an improvement or new feature
Description
Currently, most of the zkevm tests will fail in Osaka because it introduces a max transaction gas limit of 30M gas per transaction.
Since most of the tests currently use a single tx that fills the block, we need to change the approach to split the benchmarking tests into multiple txs.
We should read fork.transaction_gas_limit_cap() in each test and:
- If the result is
None, assume a tx can take up the entire block gas limit and continue normally. - If the result is not
Nonebut greater thanEnvironment().gas_limit, assume a tx can take up the entire block gas limit and continue normally. - If the result is not
Noneand lower or equal toEnvironment().gas_limit, change the logic to send multiple transactions to be able to fill the block.
LouisTsai-Csie, jsign and fselmo
Metadata
Metadata
Assignees
Labels
A-test-benchmarkArea: Tests Benchmarks—Performance measurement (eg. `tests/benchmark/*`, `p/t/s/e/benchmark/*`)Area: Tests Benchmarks—Performance measurement (eg. `tests/benchmark/*`, `p/t/s/e/benchmark/*`)C-enhanceCategory: an improvement or new featureCategory: an improvement or new feature