Skip to content

Adapt zkevm tests to account for fork.transaction_gas_limit_cap (EIP-7825) #1557

@marioevz

Description

@marioevz

Currently, most of the zkevm tests will fail in Osaka because it introduces a max transaction gas limit of 30M gas per transaction.

Since most of the tests currently use a single tx that fills the block, we need to change the approach to split the benchmarking tests into multiple txs.

We should read fork.transaction_gas_limit_cap() in each test and:

  • If the result is None, assume a tx can take up the entire block gas limit and continue normally.
  • If the result is not None but greater than Environment().gas_limit, assume a tx can take up the entire block gas limit and continue normally.
  • If the result is not None and lower or equal to Environment().gas_limit, change the logic to send multiple transactions to be able to fill the block.

cc @jsign @jochem-brouwer @LouisTsai-Csie

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-test-benchmarkArea: Tests Benchmarks—Performance measurement (eg. `tests/benchmark/*`, `p/t/s/e/benchmark/*`)C-enhanceCategory: an improvement or new feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions