Skip to content

Conversation

@obatirou
Copy link
Contributor

@obatirou obatirou commented Jan 27, 2025

What was wrong?

Logs, error and touched_accounts can have stricter types

Related to Issue #1097

How was it fixed?

Stricter types

  • logs: Union[Tuple[()], Tuple[Log, ...] to Tuple[Log, ...] (redundant)
  • errors: Option[Exception] to Option[EthereumException]
  • touched_accounts: Iterable type to Set

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.90%. Comparing base (da1e112) to head (0b2b825).
Report is 76 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
+ Coverage   83.59%   84.90%   +1.30%     
==========================================
  Files         644      649       +5     
  Lines       36123    36078      -45     
==========================================
+ Hits        30198    30633     +435     
+ Misses       5925     5445     -480     
Flag Coverage Δ
unittests 84.90% <100.00%> (+1.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gurukamath gurukamath merged commit 9923823 into ethereum:master Jan 31, 2025
4 of 5 checks passed
gurukamath added a commit to gurukamath/execution-specs that referenced this pull request Jan 31, 2025
gurukamath added a commit that referenced this pull request Feb 3, 2025
* port #1098 to prague

* port #1011 to prague
nerolation pushed a commit to nerolation/execution-specs that referenced this pull request Feb 7, 2025
nerolation pushed a commit to nerolation/execution-specs that referenced this pull request Feb 9, 2025
nerolation pushed a commit to nerolation/execution-specs that referenced this pull request Feb 10, 2025
SamWilsn pushed a commit to SamWilsn/eth1.0-specs that referenced this pull request Mar 5, 2025
* dev: stricter type for MessageCallOuput

* fix: build doc
Shashwat-Nautiyal pushed a commit to Shashwat-Nautiyal/execution-specs that referenced this pull request Mar 17, 2025
* dev: stricter type for MessageCallOuput

* fix: build doc
Shashwat-Nautiyal pushed a commit to Shashwat-Nautiyal/execution-specs that referenced this pull request Mar 20, 2025
* dev: stricter type for MessageCallOuput

* fix: build doc
fselmo pushed a commit to fselmo/execution-specs that referenced this pull request Apr 9, 2025
SamWilsn pushed a commit to SamWilsn/eth1.0-specs that referenced this pull request Apr 11, 2025
SamWilsn pushed a commit that referenced this pull request May 15, 2025
* port #1098 to prague

* port #1011 to prague
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants