feat(osaka): add eip-7939 count leading zeros opcode #1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurukamath
approved these changes
Jun 10, 2025
gurukamath
reviewed
Jun 23, 2025
Co-authored-by: Guruprasad Kamath <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devnets/osaka/2 #1275 +/- ##
==================================================
Coverage ? 92.97%
==================================================
Files ? 582
Lines ? 33722
Branches ? 3066
==================================================
Hits ? 31353
Misses ? 1839
Partials ? 530
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| x = pop(evm.stack) | ||
|
|
||
| # GAS | ||
| charge_gas(evm, GAS_VERY_LOW) |
Member
There was a problem hiding this comment.
Small nit: we want to charge gas before doing any operations. So the gas should be charged before the pop. If there is not enough gas available, then we thus also do not perform the pop logic where there are insufficient funds for 😄 👍
SamWilsn
pushed a commit
that referenced
this pull request
Jun 26, 2025
* feat(vm): add eip-7939 count leading zeros opcode. * Update src/ethereum/osaka/vm/instructions/bitwise.py Co-authored-by: Guruprasad Kamath <[email protected]> * code formatting --------- Co-authored-by: Guruprasad Kamath <[email protected]> Co-authored-by: Guruprasad Kamath <[email protected]>
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
Jul 18, 2025
* feat(vm): add eip-7939 count leading zeros opcode. * Update src/ethereum/osaka/vm/instructions/bitwise.py Co-authored-by: Guruprasad Kamath <[email protected]> * code formatting --------- Co-authored-by: Guruprasad Kamath <[email protected]> Co-authored-by: Guruprasad Kamath <[email protected]>
Carsons-Eels
pushed a commit
to Carsons-Eels/execution-specs
that referenced
this pull request
Jul 22, 2025
* feat(vm): add eip-7939 count leading zeros opcode. * Update src/ethereum/osaka/vm/instructions/bitwise.py Co-authored-by: Guruprasad Kamath <[email protected]> * code formatting --------- Co-authored-by: Guruprasad Kamath <[email protected]> Co-authored-by: Guruprasad Kamath <[email protected]>
SamWilsn
pushed a commit
to SamWilsn/eth1.0-specs
that referenced
this pull request
Jul 25, 2025
* feat(vm): add eip-7939 count leading zeros opcode. * Update src/ethereum/osaka/vm/instructions/bitwise.py Co-authored-by: Guruprasad Kamath <[email protected]> * code formatting --------- Co-authored-by: Guruprasad Kamath <[email protected]> Co-authored-by: Guruprasad Kamath <[email protected]>
nerolation
pushed a commit
to nerolation/execution-specs
that referenced
this pull request
Aug 1, 2025
* feat(vm): add eip-7939 count leading zeros opcode. * Update src/ethereum/osaka/vm/instructions/bitwise.py Co-authored-by: Guruprasad Kamath <[email protected]> * code formatting --------- Co-authored-by: Guruprasad Kamath <[email protected]> Co-authored-by: Guruprasad Kamath <[email protected]>
Carsons-Eels
pushed a commit
to Carsons-Eels/execution-specs
that referenced
this pull request
Oct 16, 2025
danceratopz
pushed a commit
to danceratopz/execution-specs
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the CLZ (count leading zeros opcode) for EIP-7939.
Cute Animal Picture