feat(specs): Add EIP-7981 implementation #1384
Open
+11,478
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurukamath
reviewed
Sep 1, 2025
src/ethereum/osaka/transactions.py
Outdated
|
|
||
| for access in access_list: | ||
| # Count bytes in address (20 bytes) | ||
| for byte in access.account: |
Contributor
There was a problem hiding this comment.
Counting zero and non-zero bytes is being used in a couple of other places as well, including for call data in calculate_intrinsic_cost. Perhaps it would be a good idea to refactor it into a function in the ethereum.utils.byte module.
Contributor
Author
There was a problem hiding this comment.
yeah agree, makes sense
danceratopz
pushed a commit
to danceratopz/execution-specs
that referenced
this pull request
Oct 22, 2025
This combines the cases of `test_all_opcodes_stack_underflow()` to `test_all_opcodes_variadic_stack_underflow()`. By the way, this also improves some details, e.g. avoids instruction sequence as `RETURN STOP`.
Add additional gas costs for access list data bytes as specified in EIP-7981. - Add count_bytes utility function for zero/non-zero byte counting - Add EIP-7981 gas cost constants for access list bytes - Add count_access_list_bytes function to count bytes in access lists - Modify calculate_intrinsic_cost to include EIP-7981 access list data costs - Update function documentation to reference EIP-7981 Maintains compatibility with existing EIP-2930 access list functionality.
nerolation
changed the title
fselmo
force-pushed
the
forks/amsterdam
branch
3 times, most recently
from
28a68cd to
cb3daac
Compare
fselmo
force-pushed
the
forks/amsterdam
branch
from
cb3daac to
dfeccbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft implementation of EIP-7981, which is going to be proposed for Glamsterdam.