abigen - Failed to generate ABI binding: duplicated identifier "totalSupply"(normalized "TotalSupply"), use --alias for renaming

[huahuayu]

System information

geth: 1.9.24-unstable
solc: 0.4.17+commit.bdeb9e52.Linux.g++
abigen: abigen version 1.9.24-unstable

Expected behavior

get TetherToken.sol from https://etherscan.io/address/0xdac17f958d2ee523a2206206994597c13d831ec7#code

generate go code by abigen successfully

Actual behaviour

abigen failed

$ abigen -sol TetherToken.sol -pkg usdt -out usdt.go
Fatal: Failed to generate ABI binding: duplicated identifier "totalSupply"(normalized "TotalSupply"), use --alias for renaming

[huahuayu]

@karalabe I have seen you discuss the duplicated identifier issue, can you please guide how to deal with it?

related issue: miguelmota/ethereum-development-with-go-book#56

[ligi]

./build/bin/abigen -sol tmp/token.sol --pkg usdt -out usdt.go --alias _totalSupply=yourOtherName
Please let us know how to improve the error message so it is more obvious - I thought use --alias for renaming is quite obvious

[huahuayu]

@ligi but from the abigen -h, it's said, it's comma-separated, so I tried

abigen --bin=bin/TetherToken.bin --abi=abi/Contract.abi --pkg=usdt --out=usdt.go --alias=totalSupply,totalSupply1

so the help information is missleading?

[ligi]

coma separated in case there is more than one replacement. How would you write it so it is better understandable?

[huahuayu]

how about this?

 --alias value                      Comma separated aliases for function and event renaming, e.g. foo=_foo, bar=_bar

[rjl493456442]

@huahuayu Feel free to open a PR for the doc.

[huahuayu]

@rjl493456442 👌

[huahuayu]

I have raised a pr for this, pending review

#21875