Remaining Hive Cancun Test Failures

[spencer-tb]

Description

I'm tagging the last 5 failures here for the hive cancun tests. Specifically from the engine-cancun simulator.

(note: on hivecancun all other failures pass locally and are due to something internal to the CI).

ForkchoiceUpdatedV3 To Request Shanghai Payload, Null Beacon Root
ForkchoiceUpdatedV2 To Request Shanghai Payload, Non-Null Beacon Root
ForkchoiceUpdatedV2 To Request Cancun Payload, Non-Null Beacon Root
Invalid PayloadAttributes, Missing BeaconRoot, Syncing=False
Invalid PayloadAttributes, Missing BeaconRoot, Syncing=True

These can all be explained from the execution apis spec update in ethereum/execution-apis#498.

For the first 4 tests:

ForkchoiceUpdatedV3 To Request Shanghai Payload, Null Beacon Root
ForkchoiceUpdatedV2 To Request Shanghai Payload, Non-Null Beacon Root
ForkchoiceUpdatedV2 To Request Cancun Payload, Non-Null Beacon Root
Invalid PayloadAttributes, Missing BeaconRoot, Syncing=False

We are essentially sending an fcu with invalid payload attributes and hence expect an error reponse of INVALID_PAYLOAD_ATTRIBUTES. Geth is returning INVALID_PARAMS.

For the 5th test case where we are syncing:

Invalid PayloadAttributes, Missing BeaconRoot, Syncing=True

We expect no error response, as from the execution apis PR above, if a client is syncing no payload attributes validations should be ran. Currently geth returns with INVALID_PARAMS.

Steps to reproduce

Using the latest version of hive run the following command:

./hive --sim ethereum/engine --client go-ethereum --client-file configs/cancun.yaml --docker.output --sim.limit engine-cancun/"<test_name>"

[holiman]

Assuming this is fixed ( @lightclient ?)

[lightclient]

Sorry these are not resolved yet.

[fjl]

@lightclient should this be closed?