Skip to content

rpc api: eth_getNatSpec #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2015
Merged

rpc api: eth_getNatSpec #1919

merged 1 commit into from
Oct 28, 2015

Conversation

@zelig
Copy link
Contributor

@zelig zelig commented Oct 21, 2015

  • xeth, rpc: implement eth_getNatSpec for tx confirmations
  • rename silly docserver -> httpclient
  • eth/backend: httpclient now accessible via eth.Ethereum init-d via config.DocRoot
  • cmd: introduce separate CLI flag for DocRoot (defaults to homedir)
  • common/path: delete unused assetpath func, separate HomeDir func

fixes #1913

@zelig zelig self-assigned this Oct 21, 2015
@robotally
Copy link

Vote Count Reviewers
👍 2 @Gustav-Simonsson @bas-vk
👎 0

Updated: Tue Oct 27 11:32:53 UTC 2015

@codecov-io
Copy link

Current coverage is 48.06%

Merging #1919 into develop will not affect coverage as of a246e6c

Powered by Codecov. Updated on successful CI builds.

@tgerring
Copy link
Contributor

Will this conflict with #1912 ?

@bas-vk
Copy link
Member

bas-vk commented Oct 23, 2015

@tgerring, no. The migration to the new rpc layer is work in progress.
@zelig, will this method also be implemented in the other nodes?

Gustav-Simonsson
Gustav-Simonsson reviewed Oct 26, 2015
View reviewed changes
common/httpclient/httpclient.go Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would recommend to avoid naked returns; afaik we're moving away from them in the code base unless there is some specific reason. @karalabe recently explained some reasons for when they could be used in a comment to another PR: #1917 (comment)

@zelig
rpc api: eth_getNatSpec
4d005a2 
* xeth, rpc: implement eth_getNatSpec for tx confirmations
* rename silly docserver -> httpclient
* eth/backend: httpclient now accessible via eth.Ethereum init-d via config.DocRoot
* cmd: introduce separate CLI flag for DocRoot (defaults to homedir)
* common/path: delete unused assetpath func, separate HomeDir func
@bas-vk
Copy link
Member

bas-vk commented Oct 27, 2015

👍

@frozeman
Copy link
Contributor

Could you please give an example in and put output for this new endpoint so i can judge?
Im currently busy with the custom coin branch so i don't want to switch now

@Gustav-Simonsson
Copy link

👍

@zelig zelig mentioned this pull request Oct 28, 2015
Merged
obscuren added a commit that referenced this pull request Oct 28, 2015
@obscuren
Merge pull request #1919 from ethersphere/getnatspec
05f7407 
rpc api: eth_getNatSpec
@obscuren obscuren merged commit 05f7407 into ethereum:develop Oct 28, 2015
@obscuren obscuren removed the review label Oct 28, 2015
@obscuren obscuren mentioned this pull request Oct 28, 2015
Closed
@obscuren obscuren modified the milestone: 1.3.0 Oct 30, 2015
@zelig zelig deleted the getnatspec branch November 29, 2016 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@zelig zelig

Labels

type:feature

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

8 participants

@zelig @robotally @codecov-io @tgerring @bas-vk @frozeman @Gustav-Simonsson @obscuren