fix panic on bad tx sender #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok see test in #196 |
acud
pushed a commit
to acud/go-ethereum
that referenced
this pull request
Mar 1, 2018
[Store] Allow parameters to be set via cli and env vars
ngtuna
added a commit
to ngtuna/tomochain
that referenced
this pull request
Sep 27, 2018
bump up v0.2.2
AusIV
pushed a commit
to NoteGio/go-ethereum
that referenced
this pull request
Nov 12, 2020
propose mess mainnet block
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Aug 13, 2021
* syncservice: update ethsign enum * types: fix build
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this pull request
Jan 20, 2022
jonkofee
pushed a commit
to jonkofee/go-ethereum
that referenced
this pull request
Jan 25, 2023
Mark startup later for the unclean shutdown tracker
jsign
added a commit
to jsign/go-ethereum
that referenced
this pull request
Apr 4, 2023
* fix compilation error Signed-off-by: Ignacio Hagopian <[email protected]> * print root in hex Signed-off-by: Ignacio Hagopian <[email protected]> * verkle/stage2: print elapsed time Signed-off-by: Ignacio Hagopian <[email protected]> * formatting Signed-off-by: Ignacio Hagopian <[email protected]> * Remove note-to-self comments in Frenglish --------- Signed-off-by: Ignacio Hagopian <[email protected]> Co-authored-by: Guillaume Ballet <[email protected]>
s1na
pushed a commit
to s1na/go-ethereum
that referenced
this pull request
Dec 2, 2024
…form-for-devnet finalise terraform for xdc devnet
yysung1123
pushed a commit
to getamis/go-ethereum
that referenced
this pull request
Oct 24, 2025
## Why this should be merged `goheader` linter apparently hasn't been running but now decided to and is blocking another PR. It's not worth the time to investigatie why (probably a version update). ## How this works Update header comments as required. ## How this was tested N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction pool would panic on processing a tx with a bad sig.
I can push an example branch with a script showing the panic but it required exporting a
BadSigfunction fromchain/types/transaction.gofor convenience (of course, an attacker could just hand craft the rlp tx bytes himself to trigger this). I suppose I should add atransaction_pool_test.gowith a bunch of handcrafted malicious txs. Here's the fix in the meantime. Have I missed something, or was there no signature check up to now?Note the panic was on the
GetAccount, which ultimately triggered https://github.com/ethereum/go-ethereum/blob/develop/trie/trie.go#L299