core/state/pruner: fix compaction after pruning #22291
Merged
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Feb 8, 2021
| if err := maindb.Compact([]byte{b}, []byte{b + 1}); err != nil { | ||
| var ( | ||
| start = []byte{b << 4} | ||
| end = []byte{(b+1)<<4 - 1} |
There was a problem hiding this comment.
I don't think this is correct either. You'll have e.g. start 0x40 and end 0x4f. But the end is the limit in the leveldb range, which is exclusive.
I think.
There was a problem hiding this comment.
Bleah, you're right.
// Limit of the key range, not include in the range.
Limit []byte
Myeah, wanna fix it? :)
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split up the compactor to have periodic progress reports, but unfortunately I messed it up and instead of having ranges of
0x0to0x1,0x1to0x2I had0x00to0x01and0x01to0x02. Thus I only compacted 1/16th of the entire range. This PR solves it by shifting the prefix byte to the high bits.