cmd/devp2p/internal/ethtest: use shared message types #22315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Feb 11, 2021
cmd/devp2p/internal/ethtest/types.go
Outdated
| Hash common.Hash // Hash of one particular block being announced | ||
| Number uint64 // Number of one particular block being announced | ||
| type NewBlockHashes struct { | ||
| *eth.NewBlockHashesPacket |
There was a problem hiding this comment.
Might be better not to embed it here. If you just use
type NewBlockHashes eth.NewBlockHashesPacket
you can still use the fields of the upstream definition, but don't need to wrap all the constructor call sites
renaynay
force-pushed
the
replace_message_types_ethtestsuite
branch
from
270c44e to
e3505e2
Compare
renaynay
force-pushed
the
replace_message_types_ethtestsuite
branch
from
e3505e2 to
5b0e3cb
Compare
renaynay
changed the title
fjl
requested changes
Feb 16, 2021
fjl
changed the title
fjl
changed the title
filipescuc
pushed a commit
to EthereumGenesys/go-ethereum
that referenced
this pull request
Mar 2, 2021
This updates the eth protocol test suite to use the message type definitions of the 'production' protocol implementation in eth/protocols/eth.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.