core, eth/tracer: initialize tracer statedb in CaptureStart #22333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
changed the title
holiman
force-pushed
the
tracer_fixes
branch
from
53039a5 to
827da14
Compare
s1na
reviewed
Feb 19, 2021
s1na
approved these changes
Feb 25, 2021
Contributor
s1na
left a comment
s1na
left a comment
There was a problem hiding this comment.
I tried using db in a tracer for both simple transfer and normal contract txes and it worked. The changes LGTM.
holiman
force-pushed
the
tracer_fixes
branch
from
827da14 to
a3309df
Compare
holiman
force-pushed
the
tracer_fixes
branch
2 times, most recently
from
41afa02 to
4c1ac6a
Compare
Merged
2 tasks
Contributor
Author
|
Fixed up, rebased, PTAL |
MariusVanDerWijden
approved these changes
Mar 25, 2021
Member
MariusVanDerWijden
left a comment
MariusVanDerWijden
left a comment
There was a problem hiding this comment.
LGTM
(only thing I would say is that ScopeContext is a bit redundant, as Scope and Context mean similar things, but I don't have a better idea)
Contributor
Author
In my mind, 'Scope' means the current call-scope, which is not per-transaction, but per So ScopeContext means "The contextual things related to a certain call-scope: like stack and memoy" |
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
…pturestart (ethereum#22333) Fixes the CaptureStart api to include the EVM, thus being able to set the statedb early on. This pr also exposes the struct we used internally in the interpreter to encapsulate the contract, mem, stack, rstack, so we pass it as a single struct to the tracer, and removes the error returns on the capture methods.
9 tasks
4 tasks
9 tasks
18 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 14, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #22276
CaptureStartapi to include theEVM, thus being able to set the statedb early on.