Skip to content

les: add trailing slash to metric namespace #22459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2021
Merged

les: add trailing slash to metric namespace #22459

merged 2 commits into from
Mar 9, 2021

Conversation

@holiman
Copy link
Contributor

@holiman holiman commented Mar 8, 2021

This might solve #22458

@holiman holiman mentioned this pull request Mar 8, 2021
Closed
@karalabe
Copy link
Member

karalabe commented Mar 8, 2021

Please replace the . too with a /.

@karalabe
Copy link
Member

karalabe commented Mar 8, 2021

Or can't we just avoid a . in the name altogether. This is a folder at the end of the day, why put a . in it?

@holiman
Copy link
Contributor Author

holiman commented Mar 8, 2021

Yeah let's just omit the .

@holiman holiman linked an issue Mar 8, 2021 that may be closed by this pull request
Prometheus metrics are broken #22458
Closed
rjl493456442
rjl493456442 approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@rjl493456442 rjl493456442 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

It's ok to rename the database folder. But should we also consider wiping the legacy les folders? e.g. les.client lespay.

@rjl493456442
Copy link
Member

rjl493456442 commented Mar 9, 2021

Oh sorry, only the metric name is changed. Then it's totally fine for me.

@holiman holiman added this to the 1.10.2 milestone Mar 9, 2021
@holiman holiman merged commit 3d299b7 into ethereum:master Mar 9, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@holiman @atif-konasl
les: fix errors in metric namespace (ethereum#22459)
d6ef5ef 
* les: add trailing slash to metric namespace

* les: omit '.' in metric namespace
@quorumbot quorumbot mentioned this pull request Apr 28, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.2

Development

Successfully merging this pull request may close these issues.

Prometheus metrics are broken

3 participants

@holiman @karalabe @rjl493456442