miner: add support for --miner.notify.full flag #22558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Martin Holst Swende <[email protected]>
holiman
reviewed
Mar 24, 2021
| return ethash.NewFaker() | ||
| case ethash.ModeTest: | ||
| log.Warn("Ethash used in test mode") | ||
| return ethash.NewTester(nil, noverify) |
There was a problem hiding this comment.
The NewTester did some more stuff that is now skipped:
func NewTester(notify []string, noverify bool) *Ethash {
ethash := &Ethash{
config: Config{PowMode: ModeTest, Log: log.Root()},
caches: newlru("cache", 1, newCache),
datasets: newlru("dataset", 1, newDataset),
update: make(chan struct{}),
hashrate: metrics.NewMeterForced(),
}
ethash.remote = startRemoteSealer(ethash, notify, noverify)
There was a problem hiding this comment.
The code in NewTester was just a copy of the normal constructor. I've fixed it now to just call that instead.
| return ethash.NewTester(nil, noverify) | ||
| case ethash.ModeShared: | ||
| log.Warn("Ethash used in shared mode") | ||
| return ethash.NewShared() |
There was a problem hiding this comment.
The idea here is to use a shared instance, but that's just ignored in these changes...?
func NewShared() *Ethash {
return &Ethash{shared: sharedEthash}
}
There was a problem hiding this comment.
This is now fixed as well. The main constructor New, now sets shared when ModeShared is used.
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
…thereum#22558) The PR implements the --miner.notify.full flag that enables full pending block notifications. When this flag is used, the block notifications sent to mining endpoints contain the complete block header JSON instead of a work package array. Co-authored-by: AlexSSD7 <[email protected]> Co-authored-by: Martin Holst Swende <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmit of #22323 with some additional fixes.
The PR implements the
--miner.notify.full flagthat enables full pending block notifications. Extends--miner.notifyflag.Notification without this flag:
Notification with this flag: