Skip to content

Fix Byzantium precompiles population. #22603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2021
Merged

Fix Byzantium precompiles population. #22603

merged 1 commit into from
Mar 30, 2021

Conversation

@nebojsa94
Copy link
Contributor

No description provided.

karalabe
karalabe approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Luckily these are only used for access lists which are introduced in Berlin. So for all the others, it's nice to have them be correct, but the variables are there more for the sake of completion than necessity. Thanks for fixing tho'!

@karalabe karalabe added this to the 1.10.2 milestone Mar 30, 2021
holiman
holiman approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah! Awesome, lgtm!

@karalabe karalabe merged commit 44fe466 into ethereum:master Mar 30, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@nebojsa94 @atif-konasl
core/vm: fix Byzantium address list (ethereum#22603)
a0f2f2b
@quorumbot quorumbot mentioned this pull request Apr 28, 2022
Merged
9 tasks
This was referenced Sep 23, 2022
Closed
Merged
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core/vm: fix Byzantium address list (ethereum#22603)
2614d53
@gzliudan gzliudan mentioned this pull request Sep 19, 2024
Merged
19 tasks
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core/vm: fix Byzantium address list (ethereum#22603)
a020259
@nebojsa94 nebojsa94 deleted the byzantium-precompiles branch December 4, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

2 more reviewers

@karalabe karalabe karalabe approved these changes

@holiman holiman holiman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.2

Development

Successfully merging this pull request may close these issues.

3 participants

@nebojsa94 @karalabe @holiman