Skip to content

Conversation

lightclient
Copy link
Member

@lightclient lightclient commented Jun 15, 2022

Follow on to #25059

Remove the use of rpc.API.Version since it is not subsequently used anywhere. It could be neat to eventually use this method to define methods like eth_callV2 or something, but that feels like far enough in the future (and uncertain enough) to deprecate the field for now.

@karalabe
Copy link
Member

Pls rebase 😬

@lightclient lightclient force-pushed the remove-version-field branch from ef4a81d to 4ee625a Compare June 15, 2022 16:49
@lightclient
Copy link
Member Author

@karalabe sorry meant to open this as draft until the other PRs are merged.

@lightclient lightclient marked this pull request as draft June 15, 2022 16:50
@lightclient lightclient force-pushed the remove-version-field branch from 4ee625a to 4d3dcf4 Compare June 21, 2022 09:08
@lightclient lightclient marked this pull request as ready for review June 27, 2022 10:39
@lightclient lightclient force-pushed the remove-version-field branch from 4d3dcf4 to 0c6f81f Compare June 27, 2022 10:40
@karalabe karalabe added this to the 1.10.21 milestone Jul 14, 2022
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit b53d382 into ethereum:master Jul 14, 2022
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Jul 14, 2022
@ethereum ethereum deleted a comment from tuanggolt Jul 15, 2022
cp-wjhan added a commit to cp-yoonjin/go-wemix that referenced this pull request Sep 26, 2023
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Apr 23, 2025
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Apr 24, 2025
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request Jun 9, 2025
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request Jun 24, 2025
gzliudan pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants