internal/ethapi: fix check legacy tx #25193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
reviewed
Jun 29, 2022
There was a problem hiding this comment.
Hi @bobpkr, since this value of that statement is always false in that location just inverting it doesn't really address the underlying issue. I actually took a stab at reworking this function a bit - maybe you could take a look at #25197 and see if it addresses your issue?
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
legacy tx must be IsLondon(head.Number) is false.
This
ifstatement, https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/transaction_args.go#L114-L119is always
falseand never processed.