Skip to content

Conversation

rjl493456442
Copy link
Member

No description provided.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but it's a bit wonky since it's hardcoded to return "" subdirs at all times, so a bit difficult to test that it works as it should. I'll trust you though :)

@rjl493456442
Copy link
Member Author

Yes, currently there is no sub-directory will be returned. But once we use freezer to store reverse-diff, or store trace-result, then these sub-ancient stores will be registered and corresponding sub-directory will be returned.

@rjl493456442 rjl493456442 force-pushed the api-for-ancient-root branch from c56f18d to a39d133 Compare August 8, 2022 02:02
@rjl493456442
Copy link
Member Author

Close it, since it's reworked in https://github.com/ethereum/go-ethereum/pull/25487/files in a cleaner approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants