eth/filters: return sender in pending tx subscription #26034
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
requested review from
MariusVanDerWijden,
gballet,
holiman,
karalabe and
rjl493456442
as code owners
s1na
commented
Oct 24, 2022
|
|
||
| // eth/filters needs to be initialized from this backend type, so methods needed by | ||
| // it must also be included here. | ||
| filters.Backend |
There was a problem hiding this comment.
I changed this to avoid circular import. This happened because I had to import internal/ethapi for the RPCTransaction type.
karalabe
reviewed
Oct 27, 2022
| // SubscribePendingTxs creates a subscription that writes transactions for | ||
| // transactions that enter the transaction pool. | ||
| func (es *EventSystem) SubscribePendingTxs(txs chan []*types.Transaction) *Subscription { | ||
| func (es *EventSystem) SubscribePendingTxs(txs chan []*ethapi.RPCTransaction) *Subscription { |
There was a problem hiding this comment.
I feel that at this point - internally - we should not shuffle RPCTransaction objects. It's fine to convert to these types at the last step before returning to the user, but it's an RPC output nicety, Geth internally should not pass around RPC related types.
|
Closing in favor of #26126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the pending tx subscription to return
RPCTransactiontypes instead of normalTransactionobjects. This will fix the inconsistencies with other tx returning API methods (i.e.getTransactionByHash), and also fill in the sender value for the tx.Fixes #26030