Skip to content

Conversation

@MariusVanDerWijden
Copy link
Member

Adds the eth/68 protocol version to the devp2p test suite

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman
Copy link
Contributor

holiman commented Nov 5, 2022

cmd/devp2p/internal/ethtest/suite.go:527:40: unnecessary conversion (unconvert)
	announce := NewPooledTransactionHashes(NewPooledTransactionHashes{Types: types, Sizes: sizes, Hashes: hashes}

@fjl fjl changed the title cmd/devp2p/internal/ethtest: add eth68 to devp2p test suite cmd/devp2p/internal/ethtest: add support for eth/68 Nov 7, 2022
@fjl fjl merged commit 055528a into ethereum:master Nov 7, 2022
@fjl fjl added this to the 1.11.0 milestone Nov 7, 2022
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
jonastheis pushed a commit to scroll-tech/go-ethereum that referenced this pull request Jun 7, 2024
Co-authored-by: Felix Lange <[email protected]>
 Conflicts:
	cmd/devp2p/internal/ethtest/helpers.go
omerfirmak pushed a commit to scroll-tech/go-ethereum that referenced this pull request Aug 6, 2024
Co-authored-by: Felix Lange <[email protected]>
 Conflicts:
	cmd/devp2p/internal/ethtest/helpers.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants