core/rawdb: improve freezerTable.Sync #26245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only invocation is https://github.com/ethereum/go-ethereum/blob/master/core/blockchain.go#L1112 In case if But the fix is definitely good. |
rjl493456442
approved these changes
Nov 24, 2022
lochjin
pushed a commit
to lochjin/go-ethereum
that referenced
this pull request
Nov 28, 2022
While investigating ethereum#22374, I noticed that the Sync operation of the freezer does not take the table lock. It also doesn't call sync for all files if there is an error with one of them. I doubt this will fix anything, but didn't want to drop the fix on the floor either. (cherry picked from commit 193f350)
dindinw
added a commit
to Qitmeer/go-ethereum
that referenced
this pull request
Nov 28, 2022
lochjin
pushed a commit
to lochjin/go-ethereum
that referenced
this pull request
Nov 30, 2022
While investigating ethereum#22374, I noticed that the Sync operation of the freezer does not take the table lock. It also doesn't call sync for all files if there is an error with one of them. I doubt this will fix anything, but didn't want to drop the fix on the floor either. (cherry picked from commit 193f350)
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
While investigating ethereum#22374, I noticed that the Sync operation of the freezer does not take the table lock. It also doesn't call sync for all files if there is an error with one of them. I doubt this will fix anything, but didn't want to drop the fix on the floor either.
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #22374, I noticed that the
Syncoperation of the freezer does not take the table lock.It also doesn't call sync for all files if there is an error with one of them.
I doubt this will fix anything, but didn't want to drop the fix on the floor either.