Implement EIP-4844 #26283
Closed
Implement EIP-4844 #26283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: lightclient <[email protected]>
Prune gokzg from crypto/kzg
…ver on array blob type
…lication-layer detail, update tests. And make kzg tests run precompiles.
We previously computed it in UnmarshalBinary() but in a wrong way (we considered the wrapped data as part of the inner length)
Fix a bunch of bugs found during development of EIP-4844 tooling
# Conflicts: # core/blockchain_test.go # core/state_transition.go # core/types/receipt.go # core/types/transaction.go # core/vm/eips.go # eth/catalyst/api.go # eth/catalyst/api_test.go # eth/catalyst/queue.go # eth/tracers/js/tracer.go # eth/tracers/native/prestate.go # go.mod # go.sum # params/config.go
Update engine capabilities set
tests: Add ShanghaiToShardingAtTime15k
* update kzg lib to latest * add check of len(proofs) per free the blobs * fix type / typo bugs * use test factory for blob wrapper test data
Dawidowak
approved these changes
Apr 17, 2023
Change Blob Transaction Type to 0x03
txpool: Update blob tx wrap data size
…le, reject 0-blob blob txs (#122)
engine: Update BlobsBundle fields
Trigger EIP-4844 on Cancun fork
Add blob length errors for engine api and transition tool.
|
This PR has been superseded by several other PRs, and will not be merged. I am closing this now, since it's no longer relevant for this repo. |
|
Thanks for your work @roberto-bayardo! It was a great help when I implemented our 4844 version. I think I even lifted some of your test cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a not-for-merging proof of concept implementation being used in the 4844 devnets.