-
Notifications
You must be signed in to change notification settings - Fork 21.5k
eth/tracers/logger: do not include elapsed time in evm output #26291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Yes on-board with this. I went ahead and wiped it from the logger interface. If a tracer needs the time they can measure it themselves. No need for evm to do this. |
s1na
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SGTM 👍 |
…erface (ethereum#26291) This removes the 'time' field from logs, as well as from the tracer interface. This change makes the trace output deterministic. If a tracer needs the time they can measure it themselves. No need for evm to do this. Co-authored-by: Sina Mahmoodi <[email protected]>
This update covers this PRs: - ethereum/go-ethereum#26414 - ethereum/go-ethereum#27183 - ethereum/go-ethereum#26291 - ethereum/go-ethereum#26048
…erface ethereum#26291 This removes the 'time' field from logs, as well as from the tracer interface. This change makes the trace output deterministic. If a tracer needs the time they can measure it themselves. No need for evm to do this. Co-authored-by: Sina Mahmoodi <[email protected]>
…erface ethereum#26291 This removes the 'time' field from logs, as well as from the tracer interface. This change makes the trace output deterministic. If a tracer needs the time they can measure it themselves. No need for evm to do this. Co-authored-by: Sina Mahmoodi <[email protected]>
…erface ethereum#26291 This removes the 'time' field from logs, as well as from the tracer interface. This change makes the trace output deterministic. If a tracer needs the time they can measure it themselves. No need for evm to do this. Co-authored-by: Sina Mahmoodi <[email protected]>
…erface ethereum#26291 (#1311) This removes the 'time' field from logs, as well as from the tracer interface. This change makes the trace output deterministic. If a tracer needs the time they can measure it themselves. No need for evm to do this. Co-authored-by: Sina Mahmoodi <[email protected]>
When working with evm traces, in tools like goevmlab, it's a bit annoying when traces are not deterministic.
Example:
The
timeis what makes the output change, and does not really bring a whole lot of added value. This PR removes thetimeelement on theoutputline.cc @s1na didn't you also gripe about this at some point?
Compatibility note
This introduces a backwards-incompatible change in the native tracing interface. The paramter
t time.Durationis dropped fromCaptureEnd.