core/txpool: remove redundant check for floatingRatio == 0 #27477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero5512
requested review from
holiman,
karalabe and
rjl493456442
as code owners
|
Care to explain? |
|
|
Thanks! Please, if possible, explain your PRs in the description. It is expected and makes the review easier for us. |
fjl
changed the title
fjl
changed the title
fjl
approved these changes
Jun 15, 2023
ok |
rjl493456442
approved these changes
Jun 15, 2023
|
Please don't merge until #27463 is in |
|
Pls rebase, the txpool package was moved to |
done |
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…ethereum#27477) floatingRatio is a constant and always non-zero. So there is no need to check for == 0.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…tio == 0 (ethereum#27477)" This reverts commit d97bfa6.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…tio == 0 (ethereum#27477)" This reverts commit d97bfa6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.