Skip to content

ethapi: add state override to estimateGas #27845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 7, 2023
Merged

ethapi: add state override to estimateGas #27845

merged 6 commits into from
Aug 7, 2023

Conversation

@amintalebi
Copy link
Contributor

@amintalebi amintalebi commented Aug 3, 2023 •
edited by s1na
Loading

Fixes #27800

@amintalebi amintalebi marked this pull request as draft August 3, 2023 14:42
@s1na
Copy link
Contributor

s1na commented Aug 3, 2023

Please update the number of parameters in internal/web3ext/web3ext.go. Otherwise the overrides won't be recognized in the console.

@amintalebi amintalebi marked this pull request as ready for review August 4, 2023 16:36
@amintalebi amintalebi requested a review from s1na as a code owner August 4, 2023 16:36
jsvisa
jsvisa reviewed Aug 5, 2023
View reviewed changes
jsvisa
jsvisa reviewed Aug 5, 2023
View reviewed changes
s1na
s1na approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@s1na s1na merged commit eeebb07 into ethereum:master Aug 7, 2023
@s1na s1na added this to the 1.12.1 milestone Aug 7, 2023
@nhtyy nhtyy mentioned this pull request Nov 9, 2023
Closed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@amintalebi @devopsbo3
internal/ethapi: add state override to estimateGas (ethereum#27845)
905a19b
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "internal/ethapi: add state override to estimateGas (ethereum#…
99a79b7 
…27845)"

This reverts commit 905a19b.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "internal/ethapi: add state override to estimateGas (ethereum#…
76d1dd8 
…27845)"

This reverts commit 905a19b.
@GDdark GDdark mentioned this pull request Nov 21, 2023
Closed
13 tasks
@TateB TateB mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s1na s1na s1na approved these changes

+1 more reviewer

@jsvisa jsvisa jsvisa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.12.1

Development

Successfully merging this pull request may close these issues.

Allow state override on eth_estimateGas

3 participants

@amintalebi @s1na @jsvisa