core: implement blobfee opcode #28098

MariusVanDerWijden · 2023-09-12T16:22:07Z

Implements the https://eips.ethereum.org/EIPS/eip-7516 opcode for cancun

core/vm/eips.go

holiman · 2023-09-14T07:53:44Z

core/evm.go

There are a lot of places that doesn't use this constructor. (Maybe we ought to make them use a constructor, becuause it's very easy to miss updating one of them)

46 places where we create a vm.BlockContext struct

The problem is that most of these cases are in tests where we only set one or two of the fields. We can't really update them to use the constructor since that will need a header to populate the fields. We could theoretically create a constructor that will set every field, but that will result in a lot of NewBlockContext(nil, nil, .-.. nil). Also we pass the struct by value very often so most of the initializatios are actually BlockCOntext{}

core/vm/opcodes.go

core/vm/eips.go

internal/ethapi/api.go

lightclient

LGTM

karalabe

We can remove the ExcessBlobGas from the vm context, its redundant with the fee

lightclient · 2023-09-26T20:04:23Z

cmd/evm/internal/t8ntool/execution.go

-	if vmContext.ExcessBlobGas != nil {
-		execRs.CurrentExcessBlobGas = (*math.HexOrDecimal64)(vmContext.ExcessBlobGas)
+	if vmContext.BlobBaseFee != nil {
+		// TODO (MariusVanDerWijden): I have no idea why we have this field at all.


I think the idea here is that if you provide parentExcessBlobGas and parentBlobGasUsed t8n will automatically calculate that block's excessBlobGas. In these instances you would probably want the calculated value output so that you can pipe it in for the next transition.

I still don't think that this is really needed

holiman · 2023-10-02T08:56:09Z

core/state_processor.go

 	if tx.Type() == types.BlobTxType {
 		receipt.BlobGasUsed = uint64(len(tx.BlobHashes()) * params.BlobTxBlobGasPerBlob)
-		receipt.BlobGasPrice = eip4844.CalcBlobFee(*evm.Context.ExcessBlobGas)
+		receipt.BlobGasPrice = evm.Context.BlobBaseFee


How come that the "gasprice" is calculated as the basefee? I mean, the base is only one part of the price, no?

There is no blob priority fee yet, so it's just base fee!

What was ExcessBlobGas exactly before?
And the concept of ExcessBlobGas no longer exists?

holiman

LGTM

Implements "EIP-7516: BLOBBASEFEE opcode" for cancun, as per spec: https://eips.ethereum.org/EIPS/eip-7516

This reverts commit 5585e79.

…71c907d1dc6504ed32a9161e71351 Merge Geth master updates starting from 766272f ending by 16ce7bf. The list of PRs that are important for us: - ethereum/go-ethereum#28147 removal of rollback mechanism in downloader. We may still need this mechanism since we're pre-merge and allow forks; - ethereum/go-ethereum@3dc45a3 related to release pipeline, example of pre-release version update; - ethereum/go-ethereum@dc34fe8 related to release pipeline, example of post-release version update; - ethereum/go-ethereum#28098 BLOBBASEFEE opcode implemented as a part of Cancun (we have to support it eventually); - ethereum/go-ethereum#28195 introduce new Cancun-related block fields to eth tools; - ethereum/go-ethereum#28243 introduce blob transactions support for internal eth services; - ethereum/go-ethereum#28084 allows to invoke contract at specific block hash, may be useful for Governance contract integration; - ethereum/go-ethereum#28538 Dockerfile.alltools update example, just to remember that it should be in sync with Dockerfile; - ethereum/go-ethereum#28605 Improved Cancun- and Shanghai- related consensus verification. Although we must enable Shanghai and Cancun in dBFT, this PR is a hint of what should be changed wrt Clique/Ethash implementation for this; - ethereum/go-ethereum#28549 GitHub actions are added for tests; - ethereum/go-ethereum#27766 Beacon Committee chain implementation (light chain that is able to verify signed blocks once synced); Signed-off-by: Anna Shaleva <[email protected]>

…1dc6504ed32a9161e71351 Merge Geth master updates starting from 766272f ending by 99dc3fe (v1.13.11 stable release). The list of PRs that are important for us: - ethereum/go-ethereum#28147 removal of rollback mechanism in downloader. We may still need this mechanism since we're pre-merge and allow forks; - ethereum/go-ethereum@3dc45a3 related to release pipeline, example of pre-release version update; - ethereum/go-ethereum@dc34fe8 related to release pipeline, example of post-release version update; - ethereum/go-ethereum#28098 BLOBBASEFEE opcode implemented as a part of Cancun (we have to support it eventually); - ethereum/go-ethereum#28195 introduce new Cancun-related block fields to eth tools; - ethereum/go-ethereum#28243 introduce blob transactions support for internal eth services; - ethereum/go-ethereum#28084 allows to invoke contract at specific block hash, may be useful for Governance contract integration; - ethereum/go-ethereum#28538 Dockerfile.alltools update example, just to remember that it should be in sync with Dockerfile; - ethereum/go-ethereum#28605 Improved Cancun- and Shanghai- related consensus verification. Although we must enable Shanghai and Cancun in dBFT, this PR is a hint of what should be changed wrt Clique/Ethash implementation for this; - ethereum/go-ethereum#28549 GitHub actions are added for tests; - ethereum/go-ethereum#27766 Beacon Committee chain implementation (light chain that is able to verify signed blocks once synced); Signed-off-by: Anna Shaleva <[email protected]>

implement BLOBBASEFEE opcode (0x4a) (ethereum#28098) Conflicts: core/evm.go core/vm/evm.go Both nitro and upstream added fields to BlockContextx. Using both. Additions: accounts/abi/bind/base.go eth/tracers/js/goja.go common.Address no longer has the Hash() function that we sometimes used. It now, however, has a Big() function. Previous calls to Address.Hash().Big() were converted to .Big()

MariusVanDerWijden requested review from holiman, karalabe and rjl493456442 as code owners September 12, 2023 16:22

lightclient reviewed Sep 12, 2023

View reviewed changes

core/vm/eips.go Outdated Show resolved Hide resolved

CarlBeek mentioned this pull request Sep 12, 2023

Add EIP: BLOBBASEFEE opcode ethereum/EIPs#7688

Merged

holiman reviewed Sep 14, 2023

View reviewed changes

rakita reviewed Sep 15, 2023

View reviewed changes

core/vm/opcodes.go Outdated Show resolved Hide resolved

jsvisa reviewed Sep 18, 2023

View reviewed changes

core/vm/eips.go Outdated Show resolved Hide resolved

MariusVanDerWijden force-pushed the blobfee-opcode branch from 3df5c8a to 7d8ad92 Compare September 21, 2023 10:05

MariusVanDerWijden added 3 commits September 21, 2023 12:06

core: implement blobfee opcode

eeff9fe

core/vm: fix copy-paste bugs

44d6276

cmd: core: apply review comments, fix t8n tool

a09c7f1

MariusVanDerWijden force-pushed the blobfee-opcode branch from 7d8ad92 to a09c7f1 Compare September 21, 2023 10:08

lightclient reviewed Sep 21, 2023

View reviewed changes

internal/ethapi/api.go Outdated Show resolved Hide resolved

MariusVanDerWijden added 2 commits September 21, 2023 17:40

core: rename blobfee -> blobbasefee

9f1bd25

core: split 4844 and 7516

14cbbfc

lightclient approved these changes Sep 25, 2023

View reviewed changes

lightclient mentioned this pull request Sep 25, 2023

cmd/evm: cancun-updates for b11r and t8n -tools #28195

Merged

lightclient added the status:triage label Sep 26, 2023

karalabe reviewed Sep 26, 2023

View reviewed changes

lightclient removed the status:triage label Sep 26, 2023

core: cmd: remove ExcessBlobGas from vm context

b56f07e

lightclient reviewed Sep 26, 2023

View reviewed changes

cmd/evm/internal/t8ntool: fix blob gas calculation

6b59ece

holiman added the cancun label Oct 2, 2023

holiman reviewed Oct 2, 2023

View reviewed changes

holiman approved these changes Oct 2, 2023

View reviewed changes

holiman added this to the 1.13.3 milestone Oct 2, 2023

holiman merged commit c39cbc1 into ethereum:master Oct 2, 2023

hyunchel pushed a commit to hyunchel/go-ethereum that referenced this pull request Oct 6, 2023

core: implement BLOBBASEFEE opcode (0x4a) (ethereum#28098)

5e18739

Implements "EIP-7516: BLOBBASEFEE opcode" for cancun, as per spec: https://eips.ethereum.org/EIPS/eip-7516

ghost pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023

core: implement BLOBBASEFEE opcode (0x4a) (ethereum#28098)

728a990

Implements "EIP-7516: BLOBBASEFEE opcode" for cancun, as per spec: https://eips.ethereum.org/EIPS/eip-7516

ghost pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 16, 2023

core: implement BLOBBASEFEE opcode (0x4a) (ethereum#28098)

76aa53e

Implements "EIP-7516: BLOBBASEFEE opcode" for cancun, as per spec: https://eips.ethereum.org/EIPS/eip-7516

devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023

core: implement BLOBBASEFEE opcode (0x4a) (ethereum#28098)

5585e79

Implements "EIP-7516: BLOBBASEFEE opcode" for cancun, as per spec: https://eips.ethereum.org/EIPS/eip-7516

devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023

Revert "core: implement BLOBBASEFEE opcode (0x4a) (ethereum#28098)"

95a9f4c

This reverts commit 5585e79.

devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023

Revert "core: implement BLOBBASEFEE opcode (0x4a) (ethereum#28098)"

d533f72

This reverts commit 5585e79.

AnnaShaleva mentioned this pull request Feb 7, 2024

Sync bane-main with original Geth master (v1.13.11 stable) bane-labs/go-ethereum#130

Merged

3 tasks

gzliudan mentioned this pull request Feb 10, 2025

implement EIP-7516 XinFinOrg/XDPoSChain#839

Merged

19 tasks

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Feb 10, 2025

core/vm: implement BLOBBASEFEE opcode 0x4a (ethereum#28098)

af4a3b0

gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Mar 26, 2025

core/vm: implement BLOBBASEFEE opcode 0x4a (ethereum#28098)

1e7586a

gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Oct 9, 2025

core/vm: implement BLOBBASEFEE opcode 0x4a ethereum#28098

b38e1b7

core: implement blobfee opcode #28098

core: implement blobfee opcode #28098

Uh oh!

Conversation

MariusVanDerWijden commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lightclient left a comment

Choose a reason for hiding this comment

Uh oh!

karalabe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

holiman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MariusVanDerWijden commented Sep 12, 2023 •

edited

Loading