eth/fetcher: fix fetcher timeout #28220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
requested review from
holiman,
karalabe and
rjl493456442
as code owners
Contributor
|
Damn, sneaky. Please change the constant type to |
Contributor
|
(sorry wrong button) |
holiman
approved these changes
Oct 3, 2023
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
I pushed a commit removing some remaining int64->time.Time coercion. LGTM now, ltgy?
Contributor
Appveyor/windows -- the new test is too much reliant on a non-sucky cpu. |
Member
Author
|
Fixed the test, I think your change slightly changed the semantic from < to <= which broke the test |
Contributor
Maybe needs a rebase or something? |
holiman
reviewed
Oct 16, 2023
MariusVanDerWijden
force-pushed
the
tx-fetcher-test
branch
from
a487e32 to
2b0f246
Compare
lightclient
approved these changes
Oct 16, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This changes fixes a bug in the fetcher, where the timeout for how long to remember underpriced transaction was erroneously compared, and the timeout never hit. --------- Co-authored-by: Martin Holst Swende <[email protected]>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit ddd8a08.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit ddd8a08.
atenjin
pushed a commit
to alt-research/go-ethereum
that referenced
this pull request
Apr 4, 2024
This changes fixes a bug in the fetcher, where the timeout for how long to remember underpriced transaction was erroneously compared, and the timeout never hit. --------- Co-authored-by: Martin Holst Swende <[email protected]>
atenjin
pushed a commit
to alt-research/go-ethereum
that referenced
this pull request
Apr 4, 2024
eth/fetcher: fix fetcher timeout (ethereum#28220)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test and fixes a corresponding bug in the tx fetcher