eth/txpool, backend: backend returns txpool's error through rpc resp and success rpc resp for tx already tracked

[zouxyan]

please check issue#31527 😊

[rjl493456442]

What kind of error did you get? We had a fix for the stale transactions #31473, probably it's enough for your case?

[zouxyan]

What kind of error did you get? We had a fix for the stale transactions #31473, probably it's enough for your case?

No, #31473 not enough 😫.

I described the specific scenario here #31527 . I sent a transaction when my account has not enough ether to pay the transaction gas. But 1.15.5 geth node has no error inside rpc response. I thought my transaction sent well. After a while I found no transaction has been sent and nothing found on Etherscan. And then I found that no error comes back with rpc eth_sendRawTransaction response if geth has locals on. 🤔

Over here discards the error from txpool when locals is on :

go-ethereum/eth/api_backend.go

Line 285 in c8a9a9c

if err != nil && locals == nil {

[MariusVanDerWijden]

Yeah thats kind of a philosophical question. Are you expecting your transaction to be executed at some point once your account is funded? If so, our behavior is expected. Are you expecting to be notified if your transaction can not be executed RIGHT NOW, then our behavior is unexpected. It looks like some people expect the former while others expect the latter. Maybe we should discuss in triage

[zouxyan]

Yeah thats kind of a philosophical question. Are you expecting your transaction to be executed at some point once your account is funded? If so, our behavior is expected. Are you expecting to be notified if your transaction can not be executed RIGHT NOW, then our behavior is unexpected. It looks like some people expect the former while others expect the latter. Maybe we should discuss in triage

🙋I'm expecting the latter.

From version 1.15.4, geth returns no rpc error from txpool's stateful validation with locals tracker on. Before that version, rpc client received a specific invalid error from geth. And I think it's kinda an Inappropriate rpc interface behavior change.

So maybe we can find a way to straight it up. 🙏

[rjl493456442]

This pull request is outdated. Please check the latest master branch to see if your issue has been resolved.