eth/filters: fix error when blockHash is used with fromBlock/toBlock #31877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
changed the title
fjl
reviewed
May 23, 2025
eth/filters/filter_system_test.go
Outdated
Contributor
There was a problem hiding this comment.
I think these tests were just meant to check that FromBlock/ToBlock is mutually exclusive with BlockHash.
Contributor
Author
There was a problem hiding this comment.
but it does not actually return any error for these cases in the GetLogs (there is an if/else check)
fjl
force-pushed
the
fix-TestInvalidGetLogsRequest
branch
from
049d47b to
57d7022
Compare
fjl
changed the title
fjl
approved these changes
Aug 1, 2025
9 tasks
howjmay
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Aug 27, 2025
…thereum#31877) This introduces an error when the filter has both `blockHash` and `fromBlock`/`toBlock`, since these are mutually exclusive. Seems the tests were actually returning `not found` error, which went undetected since there was no check on the actual returned error in the test.
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Sep 4, 2025
…thereum#31877) This introduces an error when the filter has both `blockHash` and `fromBlock`/`toBlock`, since these are mutually exclusive. Seems the tests were actually returning `not found` error, which went undetected since there was no check on the actual returned error in the test.
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
…thereum#31877) This introduces an error when the filter has both `blockHash` and `fromBlock`/`toBlock`, since these are mutually exclusive. Seems the tests were actually returning `not found` error, which went undetected since there was no check on the actual returned error in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an error when the filter has both
blockHashandfromBlock/toBlock, since these are mutually exclusive. Seems the tests were actually returningnot founderror, which went undetected since there was no check on the actual returned error in the test.