-
Notifications
You must be signed in to change notification settings - Fork 21.5k
core, params: add limit for max blobs in blob transaction #32246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
core/block_validator.go
Outdated
| } | ||
|
|
||
| // Blob transactions may be present after the Cancun fork. | ||
| isOsaka := v.config.IsOsaka(block.Number(), block.Time()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The invalid blob txs (with more than 6 blobs) will be caught in the state_transition, no matter for block processing (from network), or the block production. And this rule is also applied for RPC calls there.
The validation here is duplicated?
rjl493456442
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
…2246) [EIP-7594](https://eips.ethereum.org/EIPS/eip-7594) defines a limit of max 6 blobs per transaction. We need to enforce this limit during block processing. > Additionally, a limit of 6 blobs per transaction is introduced. Clients MUST enforce this limit when validating blob transactions at submission time, when received from the network, and during block production and processing.
…2246) [EIP-7594](https://eips.ethereum.org/EIPS/eip-7594) defines a limit of max 6 blobs per transaction. We need to enforce this limit during block processing. > Additionally, a limit of 6 blobs per transaction is introduced. Clients MUST enforce this limit when validating blob transactions at submission time, when received from the network, and during block production and processing.
EIP-7594 defines a limit of max 6 blobs per transaction. We need to enforce this limit during block processing.