cmd/evm: add stdin support to blocktest command #32824
Conversation
Enable blocktest to read filenames from stdin when no path argument is provided, matching the existing statetest behavior. This allows efficient batch processing of blockchain tests. Usage: - Single file: evm blocktest <path> - Batch mode: find tests/ -name "*.json" | evm blocktest 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
bshastry
requested review from
MariusVanDerWijden and
lightclient
as code owners
|
The lint is red @bshastry |
bshastry
force-pushed
the
cmd/evm-blocktest-stdin
branch
2 times, most recently
from
9d2a754 to
0e8268a
Compare
bshastry
force-pushed
the
cmd/evm-blocktest-stdin
branch
from
0e8268a to
94b4de0
Compare
|
Been looking a bit into this. Its seems the whole concept of EndMarker should be removed. What I guess you want is to write out the results between the traces not only at the end of the test, right? This should be possible with the traceResult struct. I will push a commit on top which changes this, we can remove it again if you don't agree |
Yeah, basically I want a read protocol for jsonl that signals when blocktest results are complete, so I can break the jsonl scanner loop. trace line 1 trace line 2... |
This commit addresses all feedback from @rjl493456442: 1. Result printing location: Removed duplicate report() call from inside test loop. Now uses dedicated traceEndMarker on stderr instead of printing full results mid-execution. 2. Fork assignment: Fork now always assigned regardless of tracer or pass/fail status. Root only assigned when test succeeds, following correct semantics. 3. Log suppression: Removed automatic log suppression. Users can control logging via standard --verbosity and --log.file flags. Only one rare INFO log exists in blocktest path. The traceEndMarker provides clear delimiter for trace parsers (e.g., goevmlab) without duplicating test results. Format: {"testEnd":{"name":"...","pass":true,"fork":"...","root":"..."}} This follows precedent from Nethermind PR ethereum#9432. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
4 participants
Enable blocktest to read filenames from stdin when no path argument is provided, matching the existing statetest behavior. This allows efficient batch processing of blockchain tests.
Usage:
🤖 Generated with Claude Code