-
Notifications
You must be signed in to change notification settings - Fork 518
internal/libhive: fix assignment to entry in nil map bug #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! |
alexshliu
pushed a commit
to taikoxyz/hive_old
that referenced
this pull request
Dec 5, 2022
fix: recover replacement feat: specify clients from command line internal/libhive: fix assignment to entry in nil map bug (ethereum#660) feat: specify clients from command line chore: delete some comments chore: rename works chore: add some comments chore: rename feat: use only one contract client to deploy all contracts chore: use optimism vault.go do some optimize rename feat: change vault address feat: fix some bug feat: update go version and taiko chain id feat: recover signer fix: chagne signer feat: optimize code feat: add l1 genesis feat: get L1 genesis feat: change some config, and run whole net sucessfully feat: chaoptimize code feat: add prover whitelist feat: opt driver pass feat: use taiko-client chore: fix useage instruction fix: update jwt token fix: fix banch name feat: jwt secret as a config restrcut: restruct devnet fix: fix config bug feat: add example test feat: fix concurrency bug feat:Run tests in parallel feat: watch prove event feat: restruct deploy config feat: restruct start net feat: deploy contracts in add l1 ndoe feat: fix a bug Revert "internal/libhive: fix assignment to entry in nil map bug (ethereum#660)" This reverts commit f0f6472.
alexshliu
pushed a commit
to taikoxyz/hive_old
that referenced
this pull request
Dec 5, 2022
…ereum#660)" This reverts commit f0f6472.
alexshliu
pushed a commit
to taikoxyz/hive_old
that referenced
this pull request
Dec 11, 2022
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
Signed-off-by: Barnabas Busa <[email protected]> Signed-off-by: Barnabas Busa <[email protected]> Signed-off-by: Parithosh Jayanthi <[email protected]> Co-authored-by: parithosh <[email protected]>
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
🤖 I have created a release *beep* *boop* --- ## [4.1.0](ethpandaops/ethereum-package@4.0.0...4.1.0) (2024-07-03) ### Features * add back k8s tests ([ethereum#699](ethpandaops/ethereum-package#699)) ([d621cf0](ethpandaops/ethereum-package@d621cf0)) * add checkpoint_enabled and checkpoint_url flags ([ethereum#689](ethpandaops/ethereum-package#689)) ([b8cd2b4](ethpandaops/ethereum-package@b8cd2b4)) * add eof support ([ethereum#682](ethpandaops/ethereum-package#682)) ([cb203ff](ethpandaops/ethereum-package@cb203ff)) * add mev relays to dora config ([ethereum#679](ethpandaops/ethereum-package#679)) ([293001a](ethpandaops/ethereum-package@293001a)) * Add static ports ([ethereum#677](ethpandaops/ethereum-package#677)) ([4f054d0](ethpandaops/ethereum-package@4f054d0)) * add ws_url to el_context ([ethereum#696](ethpandaops/ethereum-package#696)) ([26fea61](ethpandaops/ethereum-package@26fea61)) * introduce devnet_repo override ([ethereum#686](ethpandaops/ethereum-package#686)) ([9952361](ethpandaops/ethereum-package@9952361)) * use CDN URL for data snapshots used for shadow forks ([ethereum#676](ethpandaops/ethereum-package#676)) ([91dc68c](ethpandaops/ethereum-package@91dc68c)) ### Bug Fixes * besu bonsai log disable ([ethereum#673](ethpandaops/ethereum-package#673)) ([955f19f](ethpandaops/ethereum-package@955f19f)) * blockscout bad return ([ethereum#685](ethpandaops/ethereum-package#685)) ([e80870b](ethpandaops/ethereum-package@e80870b)) * bump peerdas images ([ethereum#678](ethpandaops/ethereum-package#678)) ([1acc201](ethpandaops/ethereum-package@1acc201)) * DNS-1035 label ([ethereum#697](ethpandaops/ethereum-package#697)) ([440fb31](ethpandaops/ethereum-package@440fb31)) * ephemery genesis loader ([ethereum#700](ethpandaops/ethereum-package#700)) ([0235063](ethpandaops/ethereum-package@0235063)) * ignore bootnodes if in shadowfork ([ethereum#660](ethpandaops/ethereum-package#660)) ([cda5dda](ethpandaops/ethereum-package@cda5dda)) * minimal eof ([ethereum#687](ethpandaops/ethereum-package#687)) ([26a7618](ethpandaops/ethereum-package@26a7618)) * release please manifest ([ethereum#675](ethpandaops/ethereum-package#675)) ([75ed7e1](ethpandaops/ethereum-package@75ed7e1)) * remove docker login ([ethereum#701](ethpandaops/ethereum-package#701)) ([ede5962](ethpandaops/ethereum-package@ede5962)) * return empty services ([ethereum#688](ethpandaops/ethereum-package#688)) ([6571a70](ethpandaops/ethereum-package@6571a70)) * return the correct network_id ([ethereum#705](ethpandaops/ethereum-package#705)) ([7c592f6](ethpandaops/ethereum-package@7c592f6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "environment" field is not included in the client launch configuration,
env := clientConfig.Environment(line 224) returns nil and a panicassignment to entry in nil mapis raised when we doenv["HIVE_LOGLEVEL"] = strconv.Itoa(api.env.SimLogLevel)later (line 236).