Skip to content

Conversation

@marioevz
Copy link
Member

@marioevz marioevz commented Feb 7, 2023

Adds a test in simulators/ethereum/engine to verify that sending engine_forkchoiceUpdatedV1 or engine_newPayloadV1 post-Shanghai results in InvalidParams error (-32602).

Although this is not explicitly stated in spec, it caused an issue on nimbus as geth started building a transition payload with empty withdrawals because of this.

Setting this as draft because there is nothing explicit in the spec to describe this error, but I think it should be laid out.

@mkalinin @MariusVanDerWijden

@mkalinin
Copy link

mkalinin commented Feb 8, 2023

We would have to update all V1 methods to make them return an error if they are called with post-Shanghai payload or payload attributes, moreover, the next fork would imply the same update for V2 methods and so forth.

Though, we could do that I wonder if there is another approach to address this problem as if we require CL clients to use V2 methods since Shanghai. Would we be able to test this kind of requirement in Hive?

@marioevz
Copy link
Member Author

Yes, this is addressed in #712

@fjl
Copy link
Collaborator

fjl commented Jun 20, 2024

@marioevz still want this in?

@marioevz
Copy link
Member Author

@marioevz still want this in?

I think this is way too outdated, will close for now.

@marioevz marioevz closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants