clients/besu: fix clique mining #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reversed the logic to deploy clique key to bootnode only. Original change was to avoid deploying the same clique key to 2 different nodes. Ended up stopping the deployment of the clique key to the first node causing test that rely on a single node to mine to fail due to timeout.
mattsse
pushed a commit
to mattsse/hive
that referenced
this pull request
Mar 24, 2023
Reversed the logic to deploy clique key to bootnode only. Original change was to avoid deploying the same clique key to 2 different nodes. Ended up stopping the deployment of the clique key to the first node, causing test that rely on a single node to mine to fail due to timeout.
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
Would be good to have invalid ssz objects persisted by default in case there is a consensus bug or other issue. There is not much downside to this besides slight storage increase but since states / blocks are generally small on devnets this shouldn't matter, also we prune objects after some time (15 days).
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
🤖 I have created a release *beep* *boop* --- ## [4.2.0](ethpandaops/ethereum-package@4.1.0...4.2.0) (2024-08-19) ### Features * add customizable configuraiton for prometheus retention ([ethereum#745](ethpandaops/ethereum-package#745)) ([6c02dfe](ethpandaops/ethereum-package@6c02dfe)) * add genesis_gaslimit param configuration ([ethereum#726](ethpandaops/ethereum-package#726)) ([a4ba9a6](ethpandaops/ethereum-package@a4ba9a6)) * Add Lighthouse PeerDAS Dashboard ([ethereum#736](ethpandaops/ethereum-package#736)) ([ffbfde2](ethpandaops/ethereum-package@ffbfde2)) * add peerdas-electra-support ([ethereum#740](ethpandaops/ethereum-package#740)) ([663e7e6](ethpandaops/ethereum-package@663e7e6)) * add profiling for prysm ([ethereum#722](ethpandaops/ethereum-package#722)) ([7dc6660](ethpandaops/ethereum-package@7dc6660)) * add sanity check ([ethereum#710](ethpandaops/ethereum-package#710)) ([b824cac](ethpandaops/ethereum-package@b824cac)) * enable dora pprof ([ethereum#743](ethpandaops/ethereum-package#743)) ([2b7be9a](ethpandaops/ethereum-package@2b7be9a)) * generate keys if not default key is used ([ethereum#707](ethpandaops/ethereum-package#707)) ([2d1cab5](ethpandaops/ethereum-package@2d1cab5)) * lodestar persists invalid ssz objects by default ([ethereum#730](ethpandaops/ethereum-package#730)) ([5a45991](ethpandaops/ethereum-package@5a45991)) * update egg config parameters ([ethereum#737](ethpandaops/ethereum-package#737)) ([78c2bc7](ethpandaops/ethereum-package@78c2bc7)) ### Bug Fixes * add debug ns to nethermind ([ethereum#732](ethpandaops/ethereum-package#732)) ([372bb52](ethpandaops/ethereum-package@372bb52)) * allow vc properties in participants_matrix.cl ([ethereum#715](ethpandaops/ethereum-package#715)) ([c8b9b19](ethpandaops/ethereum-package@c8b9b19)) * besu devnet schedule ([ethereum#734](ethpandaops/ethereum-package#734)) ([28b67cd](ethpandaops/ethereum-package@28b67cd)) * blobscan redis dependency ([ethereum#712](ethpandaops/ethereum-package#712)) ([0ed1c9c](ethpandaops/ethereum-package@0ed1c9c)) * change churn limit default for pectra tests ([ethereum#747](ethpandaops/ethereum-package#747)) ([8109054](ethpandaops/ethereum-package@8109054)) * correctly apply extra params if builder is enabled ([ethereum#725](ethpandaops/ethereum-package#725)) ([a94caf0](ethpandaops/ethereum-package@a94caf0)) * disable all assertoor tests by default ([ethereum#738](ethpandaops/ethereum-package#738)) ([2961f96](ethpandaops/ethereum-package@2961f96)) * lodestar vc faster startup ([ethereum#721](ethpandaops/ethereum-package#721)) ([225e3d8](ethpandaops/ethereum-package@225e3d8)) * readme eof ([ethereum#739](ethpandaops/ethereum-package#739)) ([7f94f6e](ethpandaops/ethereum-package@7f94f6e)) * remove custom peerdas images for dora & assertoor ([ethereum#741](ethpandaops/ethereum-package#741)) ([a19398d](ethpandaops/ethereum-package@a19398d)) * remove subscribe all subnet nimbus ([ethereum#719](ethpandaops/ethereum-package#719)) ([ef92f8f](ethpandaops/ethereum-package@ef92f8f)) * remove subscribe-all-subnets from default prysm config ([ethereum#717](ethpandaops/ethereum-package#717)) ([6348c0b](ethpandaops/ethereum-package@6348c0b)) * remove subscribe-all-subnets lighthouse/lodestar/teku ([ethereum#720](ethpandaops/ethereum-package#720)) ([cdb20e1](ethpandaops/ethereum-package@cdb20e1)) * update snapshots URL ([ethereum#731](ethpandaops/ethereum-package#731)) ([f9269ad](ethpandaops/ethereum-package@f9269ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse the logic to deploy clique key to bootnode only.
This commit 104c185 introduced an additional check to prevent deploying the same private key to a second node. Accidentally ended up stopping the deployment of the key for the first node which prevents besu from mining a block using clique and broke a couple of the RPC suite tests.
Please kindly review that and let me know if there's any additional changes required.
This change has been tested running hive locally and fixes the RPC suite. Didn't detect any new regression