Skip to content

Conversation

@g11tech
Copy link
Contributor

@g11tech g11tech commented Aug 3, 2022

Update mergeForkIdTransition hardfork schedule

image

Reference: ethereum/execution-specs#564

@g11tech g11tech added PR state: merge ready package: common target: master Work to be done towards master branch labels Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #2098 (5ae37b4) into master (5dc46fe) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 83.81% <ø> (ø)
blockchain 80.54% <ø> (ø)
client 78.22% <ø> (ø)
common 95.31% <ø> (+0.31%) ⬆️
devp2p 82.68% <ø> (+0.06%) ⬆️
ethash 90.81% <ø> (ø)
evm 40.94% <ø> (ø)
statemanager 84.55% <ø> (ø)
trie 81.35% <ø> (-1.06%) ⬇️
tx 92.20% <ø> (ø)
util 87.22% <ø> (ø)
vm 78.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@g11tech g11tech changed the title common: Update the mergeForkIdTransition hardfork schedule common: Update the mergeForkIdTransition hardfork schedule for sepolia Aug 3, 2022
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit 1d1c4e9 into master Aug 3, 2022
@holgerd77 holgerd77 deleted the g11tech/sepoli-mergeforkid-update branch August 4, 2022 08:21
"block": null,
"forkHash": null
"block": 1735371,
"forkHash": "0xb96cbd13"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a comment above here "The forkHash will remain same as mergeForkIdTransition is post merge" but the fork hashes are not the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants