This repository was archived by the owner on Aug 2, 2021. It is now read-only.
network/stream: fix slice append bug #1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
force-pushed
the
fix-stream-quirk
branch
from
bee895e to
015cd58
Compare
zelig
approved these changes
Nov 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
streampackage where a slice representing the wanted hashes on a 0 wanted hashes message was appended to, instead of setting the slice elements which were preallocated. This resulted in the firstlen(msg.Hashes)to be zero address hashes, and the secondlen(msg.Hashes)to be the actual hashes.In turn, in
localstore.Setthis caused an error (since the zero address chunk returned an error because it does not exist) and the rest of the hashes were not set, since the error handling inSetbails directly on the first error, instead of continuing to set the rest of the chunk addresses in the variadic function parameters.We should probably consider our error handling on if we bail immediately on error on these kind of operations. Maybe a potential partial set in this case would have prevented the problem (while masking the bug).