Skip to content
This repository was archived by the owner on Aug 2, 2021. It is now read-only.

p2p: print message code alongside decoding errors #2

Merged
merged 1 commit into from
Jan 4, 2015
Merged

p2p: print message code alongside decoding errors #2

merged 1 commit into from
Jan 4, 2015

Conversation

@fjl
Copy link

@fjl fjl commented Jan 4, 2015

No description provided.

@zelig zelig merged this pull request into ethersphere:eth.blockpool Jan 4, 2015
zelig pushed a commit that referenced this pull request Feb 14, 2015
@obscuren
Merge pull request #2 from Gustav-Simonsson/correct_ecies_shared_key_…
04c1a81 
…generation

Correct ECIES shared key length check
@fjl fjl deleted the debug-decode branch May 15, 2015 21:14
@jpeletier jpeletier mentioned this pull request Jun 21, 2018
Merged
frncmx pushed a commit that referenced this pull request Jan 25, 2019
p2p/protocols: fix rare data race in Peer.Handshake()
3d71141 
The race occurred in the `!p.Inbound()` case if `send()`
did return an error.

Write #1: in handle closure `rhs = msg` (goroutine)
Write #2: `return nil, error` => `nil` is written to `rhs` (main thread)

fixes #1160
@frncmx frncmx mentioned this pull request Jan 25, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fjl @zelig