Skip to content
This repository was archived by the owner on Aug 2, 2021. It is now read-only.

Conversation

@jpeletier
Copy link
Contributor

@jpeletier jpeletier commented Jun 19, 2018

As agreed during Tuesday's roundtable review, I am fragmenting PR #704 in incremental steps to make it easier to review. The steps are these:

@jpeletier jpeletier changed the title Client side mru step 2/4 client-side mru signatures -- step 2/4 Jun 19, 2018
@jpeletier jpeletier force-pushed the client-side-mru-step-2 branch from 110351b to 7d2254c Compare June 20, 2018 21:12
@jpeletier jpeletier changed the base branch from mru-publickey-in-key to mru-tmp-1 June 22, 2018 13:50
@jpeletier jpeletier force-pushed the client-side-mru-step-2 branch from 506040f to 8072389 Compare June 25, 2018 10:42
@jpeletier jpeletier requested review from lmars and nolash as code owners June 25, 2018 10:42
@jpeletier
Copy link
Contributor Author

Note:

In this step I made the mistake of renaming the resourceUpdate structure to resourceData. This will be undone in the next step. Sorry for the confusion.

@jpeletier
Copy link
Contributor Author

To review this step, use this link: 8dd0bef, which will show the correct diff.

@jpeletier jpeletier changed the base branch from mru-tmp-1 to mru-publickey-in-key June 25, 2018 17:35
@jpeletier jpeletier changed the base branch from mru-publickey-in-key to mru-tmp-1 June 25, 2018 17:36
@jpeletier jpeletier changed the title client-side mru signatures -- step 2/4 client-side mru signatures -- step 2/5 Jun 26, 2018
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this change. It was a mistake. In the next step it will be renamed back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to timestampprovider.go

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parseUpdate now verifies signatures and ownership, otherwise fails.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to updaterequest.go and renamed as resourceUpdateChunkDigest

Copy link
Contributor

@nolash nolash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments here:

8dd0bef

@nolash nolash merged this pull request into ethersphere:mru-tmp-1 Jun 27, 2018
@jpeletier jpeletier deleted the client-side-mru-step-2 branch July 22, 2018 08:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants