fix #4141: Avoid redundant this access during async function lowering
#4142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tiny note from someone maintaining legacy codebases — this change might have similar side effects to this recent SWC issue. Just wanted to raise it in case it’s relevant. Appreciate the great work 🙏 |
Randallstrader1221
suggested changes
Apr 23, 2025
| @@ -241,7 +241,7 @@ func TestLowerAsyncFunctions(t *testing.T) { | |||
| } | |||
| `) | |||
| // Skip forwarding altogether when parameter evaluation obviously cannot throw | |||
| expectPrintedTarget(t, 2015, "async (a, b = 123) => {console.log(a, b);}", `(a, b = 123) => __async(this, null, function* () { | |||
There was a problem hiding this comment.
- @gh repo clone microsoft/vscode-mock-debug
Randallstrader1221
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thisaccess beforesuper()call #4141