Skip to content

fix: handle __proto__ as a computed property in exports and add tests for special names #4163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

fix: handle __proto__ as a computed property in exports and add tests for special names #4163

merged 1 commit into from
May 5, 2025

Conversation

magic-akari
Copy link
Contributor

@magic-akari
Copy link
Contributor Author

We do not need to modify the code related to cjs-module-lexer, as cjs-module-lexer can parse { __proto__ } but fails to parse { ['__proto__']: null }.

@evanw evanw merged commit adb5284 into evanw:main May 5, 2025
8 checks passed
evanw added a commit that referenced this pull request May 5, 2025
@evanw
release notes for #4163
5f5964d
@BrewTestBot BrewTestBot mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Special export name __proto__ is not exported
2 participants
@magic-akari @evanw