Skip to content

fix: Ensure name_filter are local scoped #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2024
Merged

fix: Ensure name_filter are local scoped #861

merged 2 commits into from
Nov 17, 2024

Conversation

@tomasnorre
Copy link
Contributor

@tomasnorre tomasnorre commented Nov 15, 2024

Resolves #859

@tomasnorre tomasnorre marked this pull request as draft November 15, 2024 05:57
@tomasnorre tomasnorre marked this pull request as ready for review November 15, 2024 15:10
@tomasnorre
Copy link
Contributor Author

tomasnorre commented Nov 15, 2024

When #857 has been merged this can be rebased and merged too.

@tomasnorre tomasnorre added x:action/fix Fix an issue x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:size/small Small amount of work x:rep/small Small amount of reputation labels Nov 15, 2024
@mk-mxp mk-mxp added x:knowledge/none No existing Exercism knowledge required and removed x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises labels Nov 16, 2024
mk-mxp
mk-mxp approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. MacOS is so special sometimes...

I hope you can merge it without another approval after rebasing it.

@tomasnorre
Copy link
Contributor Author

tomasnorre commented Nov 17, 2024

Thanks for the contribution. MacOS is so special sometimes...

I hope you can merge it without another approval after rebasing it.

That shouldn't be a problem if there are not red lights :)

@tomasnorre tomasnorre merged commit 56214d6 into exercism:main Nov 17, 2024
12 checks passed
@tomasnorre tomasnorre deleted the fix-macos-unit-tests branch November 17, 2024 14:41
tomasnorre added a commit to tomasnorre/exercism-php that referenced this pull request Nov 17, 2024
@tomasnorre
fix: Ensure name_filter are local scoped (exercism#861)
a6109a3 
* fix: Ensure name_filter are local scoped

* fix test on macos
tomasnorre added a commit to tomasnorre/exercism-php that referenced this pull request Nov 17, 2024
@tomasnorre
fix: Ensure name_filter are local scoped (exercism#861)
4b54fd3 
* fix: Ensure name_filter are local scoped

* fix test on macos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mk-mxp mk-mxp mk-mxp approved these changes

Assignees

@tomasnorre tomasnorre

Labels

x:action/fix Fix an issue x:knowledge/none No existing Exercism knowledge required x:rep/small Small amount of reputation x:size/small Small amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Commit broken Unit Tests on MacOS but failed silently

2 participants

@tomasnorre @mk-mxp