You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a squashed commit from the following changes:
commit c1c976f
Author: Stanisław Chmiela <[email protected]>
Date: Thu Aug 20 19:05:55 2020 +0200
Make RCTCxxBridgeDelegate not care about return value of
jsExecutorFactoryForBridge
commit d1dd984
Author: Stanisław Chmiela <[email protected]>
Date: Thu Aug 20 19:06:13 2020 +0200
Make RCTCxxBridge not care about the actual protocol implemented,
only the method used
commit efd22a8
Author: Łukasz Kosmaty <[email protected]>
Date: Tue Mar 9 00:36:25 2021 +0100
[ios] Fix `EXC_BAD_ACCESS` in start method of `RCTCxxBridge` (#25)
commit 0e9b4f9
Author: Kudo Chien <[email protected]>
Date: Tue Aug 17 19:17:48 2021 +0800
support hermes for our RCTCxxBridge patch (#26)
SEL jsExecutorFactoryForBridgeSEL = @selector(jsExecutorFactoryForBridge:);
436
+
if ([self.delegate respondsToSelector:jsExecutorFactoryForBridgeSEL]) {
437
+
// Normally, `RCTCxxBridgeDelegate` protocol uses `std::unique_ptr` to return the js executor object.
438
+
// However, we needed to change the signature of `jsExecutorFactoryForBridge` to return `void *` instead. See https://github.com/expo/expo/pull/9862.
439
+
// This change works great in Expo Go because we have full control over modules initialization,
440
+
// but if someone is using our fork in the bare app, crashes may occur (`EXC_BAD_ACCESS`).
441
+
// To fix it, we need to get the return type of `jsExecutorFactoryForBridge` and handle two cases:
0 commit comments